weizhouapache commented on PR #14496:
URL: https://github.com/apache/cloudstack/pull/14496#issuecomment-6439215227
> @weizhouapache , can you think of any edge casses that might be touched?
changes make sense
when deviceId is null, it is set in `updateImportedVolume` method as below:
```
if (deviceId != null) {
vol.setDeviceId(deviceId);
} else if (type.equals(Type.ROOT)) {
vol.setDeviceId(0l);
} else {
vol.setDeviceId(1l);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
