weizhouapache commented on code in PR #14460:
URL: https://github.com/apache/cloudstack/pull/14460#discussion_r4375467908
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -5432,6 +5432,7 @@ private void
handlePowerOnReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
ActionEventUtils.onActionEvent(User.UID_SYSTEM,
Account.ACCOUNT_ID_SYSTEM, vm.getDomainId(),
EventTypes.EVENT_VM_START, "Out of band VM power on",
vm.getId(), getApiCommandResourceTypeForVm(vm).toString());
logger.info("VM {} is sync-ed to at Running state according to
power-on report from hypervisor.", vm.getInstanceName());
+ reconcileNicsForRunningVm(vm);
Review Comment:
when a running vm is reported as stopped, cloudstack will send a command to
force-stop it (I guess it is to ensure the vm is stopped) , and release the nic
when done.
as far as I know, nics_count is not used any more to determine if the
network need to be shutdown. the goal of this PR is to restore the nic state,
not nics_count. PR title should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
