Pearl1594 opened a new pull request, #14484: URL: https://github.com/apache/cloudstack/pull/14484
### Description This PR adds support for incremental volume snapshots for CLVM-NG <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor ### Screenshots (if appropriate): ### How Has This Been Tested? - [x] 5-deep ROOT incremental chain with data written between snapshots - File-level: write and change files in the guest across three snapshots; revert to the first incremental and to a mid-chain incremental, files as expected - [x] Incremental snapshot on a stopped VM (ROOT and data volumes) - [x] Incremental snapshot on a running VM with the guest writing - [x] Restore snapshots to new volumes, byte-identical to the source - [x] Create volume from snapshot; template from snapshot, VM boots - [x] Delete a middle snapshot: goes Hidden, chain intact - [x] Delete the last child - [x] Live VM migration, then incremental snapshot - [x] Volume migration across VGs, then incremental snapshot and restore - [x] Revert a data volume, then snapshot (new full after revert) - [x] ROOT revert after VM migration - [x] `snapshot.delta.max` chain rollover - [x] Live resize, then snapshot and restore - [x] Hourly snapshot policy - [x] Snapshot right after boot with the guest writing, then a stopped incremental identical to the LV - [x] Forced stop VM, restart on another host, then incremental snaps <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
