jmsperu commented on PR #12843: URL: https://github.com/apache/cloudstack/pull/12843#issuecomment-6309221841
Rebased on the latest main (27c7dc6341), so the conflicts are gone. I folded the branch into one commit because its old merge from main no longer replayed cleanly. The conflict was with #14305 (quiesce fixes) in `nasbackup.sh`: I kept its `abort_backup_job` and the domjobinfo query retries, and moved the backup timeout into a deadline at the top of the polling loop, so it also covers the retries and goes through `cleanup` (which now aborts the job before removing the destination) instead of calling `domjobabort` itself. `cleanup` keeps both the re-entry guard and the job abort. `bash -n` passes, and shellcheck shows no warnings beyond the ones already on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
