Damans227 commented on code in PR #14225:
URL: https://github.com/apache/cloudstack/pull/14225#discussion_r4284810525
##########
server/src/main/java/com/cloud/user/AccountManager.java:
##########
@@ -192,6 +192,8 @@ void buildACLViewSearchCriteria(SearchCriteria<? extends
ControlledViewEntity> s
ConfigKey<Boolean> UseSecretKeyInResponse = new
ConfigKey<Boolean>("Advanced", Boolean.class, "use.secret.key.in.response",
"false",
"This parameter allows the users to enable or disable of showing
secret key as a part of response for various APIs. By default it is set to
false.", true);
+ ConfigKey<Boolean> DisableDefaultView = new ConfigKey<>("Advanced",
Boolean.class, "disable.default.view", "false", "This defines if the account
will have access to the default view, or only to the projects it is associated
to. In the GUI, if the account does not have access to any project, the Default
View will be rendered.", true, ConfigKey.Scope.Account);
Review Comment:
does this only hide it in the ui? looks like the account can still use its
own resources outside projects through the api
##########
api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java:
##########
@@ -163,6 +163,10 @@ public class CapabilitiesResponse extends BaseResponse {
@Param(description = "Excluded and obsolete VPN customer gateway
cryptographic parameters")
private Map<String, Object> vpnCustomerGatewayParameters;
+ @SerializedName(ApiConstants.DISABLE_DEFAULT_VIEW)
+ @Param(description = "Whether the Default view should be disabled for
account.", since = "4.20.0.10-scclouds")
Review Comment:
should since be 24.0.0 here? 4.20.0.10-scclouds looks like the fork version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
