Damans227 commented on code in PR #14342:
URL: https://github.com/apache/cloudstack/pull/14342#discussion_r4271263281
##########
server/src/main/java/com/cloud/storage/secondary/SecondaryStorageVmManager.java:
##########
@@ -44,6 +44,9 @@ public interface SecondaryStorageVmManager extends Manager {
"The time interval(in millisecond) to scan whether or not system
needs more SSVM to ensure minimal standby capacity",
false);
+ ConfigKey<String> SecondaryStorageServiceOffering = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, String.class,
"secstorage.service.offering", null,
+ "UUID of the system offering used by secondary storage VMs. If not
found, ACS will create a system offering using the 'ssvm.ram.size' and
'ssvm.cpu.mhz' settings.", true, ConfigKey.Scope.Zone);
Review Comment:
should this say it falls back to the default system offering? once that
offering exists, changing ssvm.ram.size or ssvm.cpu.mhz doesnt change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
