Damans227 commented on code in PR #13058:
URL: https://github.com/apache/cloudstack/pull/13058#discussion_r4258543050
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -183,12 +188,21 @@ public void onClose(Session session, int statusCode,
String reason) throws IOExc
@OnWebSocketFrame
public void onFrame(Frame f) throws IOException {
+ if (viewer == null) {
+ logger.debug("Ignoring WebSocket frame because viewer is not
initialized yet.");
+ return;
+ }
logger.trace("Sending client [ID: {}] frame of {} bytes.",
viewer.getClientId(), f.getPayloadLength());
+ viewer.updateFrontEndActivityTime();
Review Comment:
does an open console that nobody touches ever time out? the browser keeps
asking for screen updates on its own, so every frame here looks like activity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
