Damans227 commented on code in PR #14245:
URL: https://github.com/apache/cloudstack/pull/14245#discussion_r4259235676
##########
plugins/integrations/kubernetes-service/src/main/resources/script/upgrade-kubernetes.sh:
##########
@@ -151,7 +151,13 @@ if [ -d "$BINARIES_DIR" ]; then
if [[ ${EXTERNAL_CNI} == true ]]; then
/opt/bin/kubectl apply -f ${BINARIES_DIR}/network.yaml
fi
- /opt/bin/kubectl apply -f ${BINARIES_DIR}/dashboard.yaml
+ if [ -f "${BINARIES_DIR}/headlamp.yaml" ]; then
++ /opt/bin/kubectl apply -f ${BINARIES_DIR}/headlamp.yaml
Review Comment:
can we drop the + at the start of these lines? looks like a pasted diff and
bash cant parse the script now, it fails with a syntax error at line 156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
