Damans227 commented on code in PR #14344:
URL: https://github.com/apache/cloudstack/pull/14344#discussion_r4218365401
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/motion/LinstorDataMotionStrategy.java:
##########
@@ -413,6 +445,7 @@ public void copyAsync(Map<VolumeInfo, DataStore>
volumeDataStoreMap, VirtualMach
MigrateAnswer migrateAnswer = (MigrateAnswer)
_agentManager.send(srcHost.getId(), migrateCommand);
boolean success = migrateAnswer != null &&
migrateAnswer.getResult();
+ postMigrationHandled = true;
Review Comment:
what happens if the migrate call times out while the vm is still moving?
this flag is only set after it returns, so the cleanup could delete the new
volume the vm ends up running on
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/motion/LinstorDataMotionStrategy.java:
##########
@@ -358,13 +383,17 @@ public void copyAsync(Map<VolumeInfo, DataStore>
volumeDataStoreMap, VirtualMach
boolean exactSize = needsExactSizeProp(srcVolumeInfo);
- String devPath = LinstorUtil.createResource(
- destVolumeInfo, destStoragePool, _storagePoolDao,
exactSize);
+ LinstorUtil.createResource(destVolumeInfo, destStoragePool,
_storagePoolDao, exactSize);
Review Comment:
if creating the linstor resource fails here, does the new volume row still
get left behind? it only goes into the cleanup list a few lines later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
