Damans227 commented on code in PR #14073:
URL: https://github.com/apache/cloudstack/pull/14073#discussion_r4194965693
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -5042,8 +5043,10 @@ private Long getDeviceId(UserVmVO vm, Long deviceId) {
int maxDevices = getMaxDataVolumesSupported(vm) + 2; // add 2 to
consider devices root volume and cdrom
int maxDeviceId = maxDevices - 1;
List<VolumeVO> vols = _volsDao.findByInstance(vm.getId());
+ boolean vmHasConfigDrive = vmInstanceDetailsDao.findDetail(vm.getId(),
VmDetailConstants.CONFIG_DRIVE_LOCATION) != null;
Review Comment:
what happens for a vm deployed with startvm=false and then given three data
disks? the config drive detail only shows up on first start, so the third disk
still lands on 4
##########
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java:
##########
@@ -142,7 +142,7 @@ public class ConfigDriveNetworkElement extends AdapterBase
implements NetworkEle
@Inject
private HypervisorGuruManager _hvGuruMgr;
- private final static Integer CONFIGDRIVEDISKSEQ = 4;
+ public static final Integer CONFIGDRIVEDISKSEQ = 4;
Review Comment:
what about vms that already have a data disk on 4? looks like they still
clash with the config drive on the next start after upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
