calvix commented on code in PR #14247:
URL: https://github.com/apache/cloudstack/pull/14247#discussion_r4181257083
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3613,13 +3613,15 @@ public synchronized String attachOrDetachDisk(final
Connect conn,
if (disk.getDeviceType() == DeviceType.DISK) {
if (disk.getBusType() == DiskDef.DiskBus.SCSI) {
busT = DiskDef.DiskBus.SCSI;
+ } else if (disk.getBusType() ==
DiskDef.DiskBus.VIRTIOBLK) {
Review Comment:
You are right, it can't.
The running VM reports these only as plain virtio. The method goes through
getAttachDiskBusType(), which falls back to rootDiskController, so the disk
still gets discard (tested).
SO i just removed the dead checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
