stag7824 commented on code in PR #14163: URL: https://github.com/apache/cloudstack/pull/14163#discussion_r4168034548
########## ui/public/locales/en.json: ########## @@ -1540,6 +1540,7 @@ "label.max.primary.storage": "Max. primary (GiB)", "label.max.secondary.storage": "Max. secondary (GiB)", "label.max.migrations": "Max. migrations", +"label.maxbackup": "Max. Backups", "label.maxbackups": "Max. Backups", Review Comment: Both keys are built dynamically from different API names, so I don't think either can be renamed without breaking the other screen: - The Resource Limits tab builds `label.max` + the resource type name (`ResourceLimitTab.vue:32`), and for type 12 that name is `backup`, giving `label.maxbackup`. - The backup schedule list takes its columns from the `fields` array in `storage.js` (`'maxbackups'`), and `AutogenView.vue` turns each into `label.` + the field name, giving `label.maxbackups`. Both `backup` and `maxbackups` come from the API response, so the keys follow them. Snapshots already work the same way: `label.maxsnaps` (snapshot schedule field) and `label.maxsnapshot` (resource limit) both read "Max. Snapshots". If you'd rather not have the duplicate, the alternative is to special-case backup in `ResourceLimitTab.vue` so it reuses `label.maxbackups`, but that adds code to avoid one string. Happy to do that if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
