stag7824 commented on PR #14096: URL: https://github.com/apache/cloudstack/pull/14096#issuecomment-5948371667
Synced with 4.22 to resolve the conflict with #14006, which rewrote `mountBackupDirectory` to check the mount's exit value. The normalisation still runs before the cifs `nobrl` append and before the mount, and the seven tests now capture the command through `Script.executeCommandForExitValue(timeout, ...)` instead of `executeCommand`. The diff against 4.22 is still just the two files. ``` mvn test -pl plugins/hypervisors/kvm -Dtest=LibvirtRestoreBackupCommandWrapperTest Tests run: 27, Failures: 0, Errors: 0, Skipped: 0 ``` With the `normalizeMountOptions` call removed, the same four tests fail as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
