Pearl1594 commented on code in PR #13591:
URL: https://github.com/apache/cloudstack/pull/13591#discussion_r4165546112
##########
plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java:
##########
@@ -372,6 +394,17 @@ public boolean deleteNatRule(DeleteNetrisNatRuleCommand
cmd) {
}
String natRuleName = cmd.getNatRuleName();
NatGetBody existingNatRule = netrisNatRuleExists(natRuleName);
+ // Backward compatibility: rules created before the public-IP
suffix was added use the legacy name
+ if (existingNatRule == null &&
"STATICNAT".equals(cmd.getNatRuleType())) {
+ String legacyName = getLegacyStaticNatRuleName(natRuleName);
+ if (legacyName != null) {
+ logger.debug("Static NAT rule not found with name '{}',
falling back to legacy name '{}'", natRuleName, legacyName);
+ existingNatRule = netrisNatRuleExists(legacyName);
+ if (existingNatRule != null) {
+ natRuleName = legacyName;
+ }
Review Comment:
I think this is a non issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
