bhouse-nexthop commented on PR #14109: URL: https://github.com/apache/cloudstack/pull/14109#issuecomment-5932058055
> as 82 files changed in the latest commit I would agree a new review is needed Thanks @DaanHoogland, and welcome back. The 82 files is a side effect of my force-push on 09-16, which rebased the branch onto `main`; GitHub's "changes since last review" view then includes everything that landed on `main` in between. The PR itself touches 17 files, and what is new since your approval is two commits: - 01b6871715261713ff5911263742c493a68ca585 Hold back hosts with a backlog of VMs still starting (5 files, +226/−30) - 02b9428ad4fb825749b1d3cafcaae3d6f45a8141 Rank each candidate host once, however many tags it carries (4 files, +76/−5) So the re-review is about 300 lines, not 82 files. Reviewing those two commits individually is the quickest route. @nvazquez @RosiKyu since Daan is short on time, would one of you be able to pick this up for 4.24? We've been running it in production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
