weizhouapache commented on code in PR #13325:
URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4155415218
##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -311,6 +311,10 @@ public class NetworkResponse extends
BaseResponseWithAssociatedNetwork implement
@Param(description = "MTU configured on the network VR's private
interfaces")
private Integer privateMtu;
+ @SerializedName(ApiConstants.NETWORKRATE)
+ @Param(description = "Network rate (in Mb/s) configured for the Guest
interface of this network; -1 if unlimited", since = "4.24.0")
Review Comment:
24.0
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java:
##########
@@ -68,6 +68,11 @@ public class UpdateVPCOfferingCmd extends BaseAsyncCmd
implements DomainAndZoneI
@Parameter(name = ApiConstants.SORT_KEY, type = CommandType.INTEGER,
description = "Sort key of the VPC offering, integer")
private Integer sortKey;
+ @Parameter(name = ApiConstants.PUBLIC_NETWORK_RATE, type =
CommandType.INTEGER,
+ since = "4.24.0",
Review Comment:
24.0
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java:
##########
@@ -68,6 +68,11 @@ public class UpdateVPCOfferingCmd extends BaseAsyncCmd
implements DomainAndZoneI
@Parameter(name = ApiConstants.SORT_KEY, type = CommandType.INTEGER,
description = "Sort key of the VPC offering, integer")
private Integer sortKey;
+ @Parameter(name = ApiConstants.PUBLIC_NETWORK_RATE, type =
CommandType.INTEGER,
Review Comment:
normally we do not change the properties of existing offerings, for example
cpu/memor of service offering, size of disk offering, supported network
services of network offering,
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java:
##########
@@ -165,6 +165,11 @@ public class CreateVPCOfferingCmd extends
BaseAsyncCreateCmd {
description = "True if the VPC offering is IP conserve mode
enabled, allowing public IPs to be used across multiple VPC tiers. Default
value is false")
private Boolean conserveMode;
+ @Parameter(name = ApiConstants.PUBLIC_NETWORK_RATE, type =
CommandType.INTEGER,
+ since = "4.24.0",
Review Comment:
24.0
##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -311,6 +311,10 @@ public class NetworkResponse extends
BaseResponseWithAssociatedNetwork implement
@Param(description = "MTU configured on the network VR's private
interfaces")
private Integer privateMtu;
+ @SerializedName(ApiConstants.NETWORKRATE)
+ @Param(description = "Network rate (in Mb/s) configured for the Guest
interface of this network; -1 if unlimited", since = "4.24.0")
Review Comment:
what about `PUBLIC_NETWORK_RATE` ?
do we consider in this PR, or a further PR ?
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java:
##########
@@ -68,6 +68,11 @@ public class UpdateVPCOfferingCmd extends BaseAsyncCmd
implements DomainAndZoneI
@Parameter(name = ApiConstants.SORT_KEY, type = CommandType.INTEGER,
description = "Sort key of the VPC offering, integer")
private Integer sortKey;
+ @Parameter(name = ApiConstants.PUBLIC_NETWORK_RATE, type =
CommandType.INTEGER,
+ since = "4.24.0",
+ description = "Data transfer rate in megabits per second allowed
for a VPC's public gateway (internet-facing network), created with this
offering. Use 0 for unlimited")
Review Comment:
`Default is unlimited`
`Use 0 for unlimited`
`-1 if unlimited`
can they be consistent ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
