rajiv-jain-netapp commented on code in PR #14255:
URL: https://github.com/apache/cloudstack/pull/14255#discussion_r4151923510
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -2677,6 +2680,17 @@ public BackupResponse createBackupResponse(Backup
backup, Boolean listVmDetails)
response.setToCheckpointId(backup.getToCheckpointId());
}
+ if (KBOSS_BACKUP_PROVIDER.equals(offering.getProvider()) &&
isCallerRootAdmin) {
Review Comment:
you are fetching offering from dao layer and, what if it would be null? we
can have null check here for offering to ignore NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
