DaanHoogland commented on PR #13058:
URL: https://github.com/apache/cloudstack/pull/13058#issuecomment-5911504491
@dheeraj12347 : a ai generated comment to this change:
> Heads up: this fix won't actually take effect even once merged.
>
> I traced why a changed consoleproxy.session.timeout still logs 300000 ms
after recreating the CPVM (as seen in the thread above (#)): the ConfigKey
ConsoleProxySessionTimeout (server/.../ConsoleProxyManager.java:81) is never
forwarded to the CPVM. The only place that reads it management-server-side is
the unrelated hasPreviousSession() reassignment check —
ConsoleProxyManagerImpl.finalizeVirtualMachineProfile(), which builds the
CPVM's boot args, forwards ConsoleProxySessionReconnectionWindow
(session_reconnection_window=...) but has no equivalent line for this setting.
So conf.getProperty("consoleproxy.session.timeout") on the CPVM side always
returns null, and sessionTimeoutMillis stays at its Java default of 300000
regardless of what's configured.
>
> This PR needs an additional hunk in ConsoleProxyManagerImpl.java, next to
the sessionReconnectionWindow block:
>
> Integer sessionTimeoutMillis =
ConsoleProxySessionTimeout.valueIn(datacenterId);
> if (sessionTimeoutMillis != null && sessionTimeoutMillis > 0) {
> buf.append("
consoleproxy.session.timeout=").append(sessionTimeoutMillis);
> }
>
> Without it, the WebSocket-idle-timeout and GC-thread changes in this PR
are unreachable — the config setting will keep behaving exactly as it does
today.
I think we (as in you ;) ) should add this to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
