rp- commented on PR #14203:
URL: https://github.com/apache/cloudstack/pull/14203#issuecomment-5886570400
Just tested this against #14194
And nothing breaks here against Linstor (didn't test anything else).
just that whatever patch lands first, the final merge will need this:
```
diff --git a/scripts/vm/hypervisor/kvm/nasbackup.sh
b/scripts/vm/hypervisor/kvm/nasbackup.sh
index 0d166dbc79..3658ba7972 100755
--- a/scripts/vm/hypervisor/kvm/nasbackup.sh
+++ b/scripts/vm/hypervisor/kvm/nasbackup.sh
@@ -345,11 +345,10 @@ backup_running_vm_pull() {
rm -rf "$scratch_dir"
sync
- # Statistics -- the size on the last stdout line is parsed by the Java
wrapper.
- du -sb $dest | cut -f1
-
- umount $mount_point
- rmdir $mount_point
+ backup_size=$(du -sb "$dest" 2>>"$logFile" | cut -f1) || { log -ne
"WARNING: du failed for $dest, reporting size as 0"; backup_size=0; }
+ timeout "$UNMOUNT_TIMEOUT" umount "$mount_point" 2>>"$logFile" || { log
"WARNING: umount of $mount_point failed or timed out"; true; }
+ rmdir "$mount_point" 2>>"$logFile" || { log "WARNING: rmdir of
$mount_point failed"; true; }
+ echo "BACKUP_SIZE_TOTAL=$backup_size"
}
# StorPool volume name (with the "~globalId" form the storpool/storpool_req
CLIs expect) from
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
