jmsperu commented on PR #12898: URL: https://github.com/apache/cloudstack/pull/12898#issuecomment-5859521454
Synced with 4.22 after #13877 and #14006 landed (merge 2a9bbbb3a2). Both sets of settings are kept and the enhancement flags now live in the new `runBackupScript`. One behavioural point for review: compression and LUKS encryption rewrite each backup file with `qemu-img convert`, which would flatten an incremental through its backing chain (or leave an encrypted child whose parent needs its own secret). So when `nas.backup.compression.enabled` or `nas.backup.encryption.enabled` is on for a zone, `decideChain` returns a full backup, and `nasbackup.sh` rejects `-M incremental` combined with `-c`/`-e` as a backstop (test: `decideChainReturnsLegacyFullWhenCompressionOrEncryptionEnabled`). Making both features chain-aware can follow separately if there's interest. Local results (JDK 17): NASBackupProviderTest 28/28, Restore wrapper 22/22, Take wrapper 5/5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
