resmo commented on code in PR #13889:
URL: https://github.com/apache/cloudstack/pull/13889#discussion_r3978764693
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/OAuth2AuthManagerImpl.java:
##########
@@ -282,7 +283,7 @@ private OauthProviderVO saveOauthProvider(String provider,
String description, S
oauthProviderVO.setDomainId(domainId);
oauthProviderVO.setAuthorizeUrl(authorizeUrl);
oauthProviderVO.setTokenUrl(tokenUrl);
- oauthProviderVO.setEnabled(true);
+ oauthProviderVO.setEnabled(enabled == null || enabled);
Review Comment:
the reason to default `enabled` to `true if null` here is that we want to
keep the logic for register "as is" (backwarts compatibilty) but on update, we
don't want to default it to true but null (keep value of `enabled` as is).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
