weizhouapache commented on PR #12813: URL: https://github.com/apache/cloudstack/pull/12813#issuecomment-5583975917
@Damans227 I confirmed that a primary-only snapshot (KVM+Ceph, snapshot.backup.to.secondary=false) is now cleaned up in-band. snapshot marked Destroyed, store-ref marked Destroyed, resource count decremented, RBD snapshot removed, before the volume itself is expunged. Before the fix, this same snapshot was permanently orphaned (BackedUp/Ready forever, deleteSnapshot failing). However, the method sits in the generic StorageManagerImpl.cleanupStorage(), which runs for every volume being expunged regardless of storage type, it now runs unconditionally on every volume-expunge pass rather than being gated by pool type. Could you please verify whether snapshots on primary storage are working for volumes on NFS, with snapshot.backup.to.secondary set to false? When the VM or volume has been expunged, can we still create a template, volume, or VM from its snapshot? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
