nagaboinaramgopal opened a new pull request, #14023:
URL: https://github.com/apache/cloudstack/pull/14023
### Description
`ImageStoreDetailResponse.equals()` had the value comparison inverted - it
returned `false` when the two responses had the **same** value and `true`
when
the values **differed**:
else if (this.getValue().equals(other.getValue()))
return false;
So two identical details were treated as unequal, and two details differing
only
by value were treated as equal — which corrupts any Set/Map/dedup keyed on
`ImageStoreDetailResponse`. It also threw an NPE when the value was null.
Fixed by comparing with `!Objects.equals(getValue(), other.getValue())`,
which
restores the correct result and is null-safe.
### Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [x] Minor
### How Has This Been Tested?
Added unit tests covering equal name+value, differing value, and differing
name.
Also built the standard packages and deployed on a KVM advanced zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
