winterhazel commented on code in PR #13821:
URL: https://github.com/apache/cloudstack/pull/13821#discussion_r3830597306
##########
server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java:
##########
@@ -162,14 +157,36 @@ private DnsProvider getProviderByType(DnsProviderType
type) {
throw new CloudRuntimeException("No plugin found for DNS provider
type: " + type);
}
+ /**
+ * Trims and rejects a DNS provider URL that resolves to an illegal
address before any provider client
+ * is given the chance to connect to it. See {@link
UriUtils#validateUrl(String)} for the exact rules
+ * enforced (including the requirement that the URL declares an {@code
http}/{@code https} scheme).
+ *
+ * @throws InvalidParameterValueException if the URL is blank, fails
validation
+ */
+ private void validateDnsServerUrl(String trimmedUrl, Account caller) {
Review Comment:
(from the SonarCloud code analysis)
`caller` is not used anymore.
##########
server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java:
##########
@@ -162,14 +157,36 @@ private DnsProvider getProviderByType(DnsProviderType
type) {
throw new CloudRuntimeException("No plugin found for DNS provider
type: " + type);
}
+ /**
+ * Trims and rejects a DNS provider URL that resolves to an illegal
address before any provider client
Review Comment:
```suggestion
* Rejects a DNS provider URL that resolves to an illegal address before
any provider client
```
It does not trim anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
