DaanHoogland commented on code in PR #13818:
URL: https://github.com/apache/cloudstack/pull/13818#discussion_r3749302489
##########
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java:
##########
@@ -50,9 +51,15 @@ public class ListSslCertsCmd extends BaseCmd {
@Parameter(name = ApiConstants.CERTIFICATE_ID, type = CommandType.UUID,
entityType = SslCertResponse.class, required = false, description = "ID of SSL
certificate")
private Long certId;
- @Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID,
entityType = AccountResponse.class, required = false, description = "Account
ID")
+ @Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID,
entityType = AccountResponse.class, required = false, description = "Account
ID, deprecated: use " + ApiConstants.ACCOUNT + " and " + ApiConstants.DOMAIN_ID
+ " instead")
Review Comment:
@resmo adding the account name and domainid makes sense, but that does not
mean using the accountid is deprecated, does it? I think it is still a valid
call and no reason to deprecate it exists afaics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
