weizhouapache commented on PR #13456:
URL: https://github.com/apache/cloudstack/pull/13456#issuecomment-5141551596

   @Tonitzpp 
   below is the list of usage of method `findByProjectIdAccountId`
   ```
   # git grep findByProjectIdAccountId
   
plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java:
        ProjectAccount projectAccount = 
projectAccountDao.findByProjectIdAccountId(project.getId(), accountID);
   
plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java:
        ProjectAccount projectAccount = 
projectAccountDao.findByProjectIdAccountId(project.getId(), 
userAccount.getAccountId());
   
plugins/acl/project-role-based/src/test/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessCheckerTest.java:
        
Mockito.when(projectAccountDaoMock.findByProjectIdAccountId(Mockito.anyLong(), 
Mockito.anyLong())).thenReturn(null);
   server/src/main/java/com/cloud/acl/DomainChecker.java:        ProjectAccount 
projectAccount = _projectAccountDao.findByProjectIdAccountId(project.getId(), 
caller.getAccountId());
   server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:        
_projectAccountDao.findByProjectIdAccountId(projectId, caller.getAccountId()) 
== null) {
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:        
ProjectAccountVO projectAccount = 
_projectAccountDao.findByProjectIdAccountId(projectId, accountId);
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:        
ProjectAccountVO projectAccount = 
_projectAccountDao.findByProjectIdAccountId(projectId, account.getId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:        if 
(_projectAccountDao.findByProjectIdAccountId(projectId, 
userAccount.getAccountId()) != null) {
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:             
           ProjectAccountVO futureOwner = 
_projectAccountDao.findByProjectIdAccountId(projectId, 
futureOwnerAccount.getAccountId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:             
               ProjectAccountVO currentOwner = 
_projectAccountDao.findByProjectIdAccountId(projectId, 
currentOwnerAccount.getId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:             
       ProjectAccountVO newProjectAcc = 
_projectAccountDao.findByProjectIdAccountId(projectId, 
updatedAcc.getAccountId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:            
ProjectAccount projectAccount =  
_projectAccountDao.findByProjectIdAccountId(projectId, account.getId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:        
ProjectAccount projectAccount = 
_projectAccountDao.findByProjectIdAccountId(projectId, account.getId());
   server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:             
                   ProjectAccount projectAccount = 
_projectAccountDao.findByProjectIdAccountId(projectId, accountIdFinal);
   server/src/main/java/org/apache/cloudstack/acl/ProjectRoleManagerImpl.java:  
          projectAccount = projAccDao.findByProjectIdAccountId(projectId, 
callerAcc.getAccountId());
   ```
   
   it seems not easy to evaluate the impact of the change and verify the cases 
which are impacted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to