CLOUDSTACK-7801: test_volumes.py - Fixed import and pep8 issues Signed-off-by: SrikanteswaraRao Talluri <tall...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/6d7666b1 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/6d7666b1 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/6d7666b1 Branch: refs/heads/master Commit: 6d7666b1351539b2f49deeed03b17ebd6da783bb Parents: 7b48b69 Author: Gaurav Aradhye <gaurav.arad...@clogeny.com> Authored: Tue Oct 28 12:30:22 2014 +0530 Committer: SrikanteswaraRao Talluri <tall...@apache.org> Committed: Tue Nov 4 11:54:40 2014 +0530 ---------------------------------------------------------------------- test/integration/component/test_volumes.py | 1131 ++++++++++++----------- 1 file changed, 593 insertions(+), 538 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/6d7666b1/test/integration/component/test_volumes.py ---------------------------------------------------------------------- diff --git a/test/integration/component/test_volumes.py b/test/integration/component/test_volumes.py index 36a910b..77cad54 100644 --- a/test/integration/component/test_volumes.py +++ b/test/integration/component/test_volumes.py @@ -16,13 +16,13 @@ # under the License. """ P1 tests for Volumes """ -#Import Local Modules +# Import Local Modules from nose.plugins.attrib import attr from marvin.cloudstackTestCase import cloudstackTestCase from marvin.cloudstackAPI import (listHypervisorCapabilities, attachIso, deleteVolume) -from marvin.lib.utils import cleanup_resources +from marvin.lib.utils import cleanup_resources, validateList from marvin.lib.base import (Account, ServiceOffering, VirtualMachine, @@ -31,70 +31,73 @@ from marvin.lib.base import (Account, Iso, Configurations, DiskOffering, - Domain) + Domain, + StoragePool) from marvin.lib.common import (get_domain, get_zone, get_template, get_pod) -#Import System modules +from marvin.codes import PASS +# Import System modules import time class Services: + """Test Volume Services """ def __init__(self): self.services = { - "account": { - "email": "t...@test.com", - "firstname": "Test", - "lastname": "User", - "username": "test", - # Random characters are appended for unique - # username - "password": "password", - }, - "service_offering": { - "name": "Tiny Instance", - "displaytext": "Tiny Instance", - "cpunumber": 1, - "cpuspeed": 100, # in MHz + "account": { + "email": "t...@test.com", + "firstname": "Test", + "lastname": "User", + "username": "test", + # Random characters are appended for unique + # username + "password": "password", + }, + "service_offering": { + "name": "Tiny Instance", + "displaytext": "Tiny Instance", + "cpunumber": 1, + "cpuspeed": 100, # in MHz "memory": 128, # In MBs - }, - "disk_offering": { - "displaytext": "Small", - "name": "Small", - "disksize": 1 - }, - "volume": { - "diskname": "TestDiskServ", - }, - "virtual_machine": { - "displayname": "testVM", - "hypervisor": 'XenServer', - "protocol": 'TCP', - "ssh_port": 22, - "username": "root", - "password": "password", - "privateport": 22, - "publicport": 22, - }, - "iso": # ISO settings for Attach/Detach ISO tests - { - "displaytext": "Test ISO", - "name": "testISO", - "url": "http://people.apache.org/~tsp/dummy.iso";, - # Source URL where ISO is located - "ostype": 'CentOS 5.3 (64-bit)', - }, - "custom_volume": { - "customdisksize": 2, - "diskname": "Custom disk", - }, - "sleep": 50, - "ostype": 'CentOS 5.3 (64-bit)', - } + }, + "disk_offering": { + "displaytext": "Small", + "name": "Small", + "disksize": 1 + }, + "volume": { + "diskname": "TestDiskServ", + }, + "virtual_machine": { + "displayname": "testVM", + "hypervisor": 'XenServer', + "protocol": 'TCP', + "ssh_port": 22, + "username": "root", + "password": "password", + "privateport": 22, + "publicport": 22, + }, + "iso": # ISO settings for Attach/Detach ISO tests + { + "displaytext": "Test ISO", + "name": "testISO", + "url": "http://people.apache.org/~tsp/dummy.iso";, + # Source URL where ISO is located + "ostype": 'CentOS 5.3 (64-bit)', + }, + "custom_volume": { + "customdisksize": 2, + "diskname": "Custom disk", + }, + "sleep": 50, + "ostype": 'CentOS 5.3 (64-bit)', + } class TestAttachVolume(cloudstackTestCase): @@ -111,24 +114,24 @@ class TestAttachVolume(cloudstackTestCase): cls.pod = get_pod(cls.api_client, cls.zone.id) cls.services['mode'] = cls.zone.networktype cls.disk_offering = DiskOffering.create( - cls.api_client, - cls.services["disk_offering"] - ) + cls.api_client, + cls.services["disk_offering"] + ) template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id - #get max data volumes limit based on the hypervisor type and version + # get max data volumes limit based on the hypervisor type and version listHost = Host.list( - cls.api_client, - type ='Routing', - zoneid = cls.zone.id, - podid = cls.pod.id, - ) + cls.api_client, + type='Routing', + zoneid=cls.zone.id, + podid=cls.pod.id, + ) ver = listHost[0].hypervisorversion hv = listHost[0].hypervisor cmd = listHypervisorCapabilities.listHypervisorCapabilitiesCmd() @@ -143,27 +146,27 @@ class TestAttachVolume(cloudstackTestCase): cls.services["volume"]["max"] = cls.max_data_volumes # Create VMs, NAT Rules etc cls.account = Account.create( - cls.api_client, - cls.services["account"], - domainid=cls.domain.id - ) + cls.api_client, + cls.services["account"], + domainid=cls.domain.id + ) cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls.virtual_machine = VirtualMachine.create( - cls.api_client, - cls.services["virtual_machine"], - accountid=cls.account.name, - domainid=cls.account.domainid, - serviceofferingid=cls.service_offering.id, - ) + cls.api_client, + cls.services["virtual_machine"], + accountid=cls.account.name, + domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, + ) cls._cleanup = [ - cls.service_offering, - cls.disk_offering, - cls.account - ] + cls.service_offering, + cls.disk_offering, + cls.account + ] def setUp(self): @@ -176,18 +179,20 @@ class TestAttachVolume(cloudstackTestCase): cleanup_resources(self.apiclient, self.cleanup) except Exception as e: self.debug("Warning: Exception during cleanup : %s" % e) - #raise Exception("Warning: Exception during cleanup : %s" % e) + # raise Exception("Warning: Exception during cleanup : %s" % e) return @classmethod def tearDownClass(cls): try: - cls.api_client = super(TestAttachVolume, cls).getClsTestClient().getApiClient() + cls.api_client = super( + TestAttachVolume, + cls).getClsTestClient().getApiClient() cleanup_resources(cls.api_client, cls._cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) - @attr(tags = ["advanced", "advancedns", "needle"]) + @attr(tags=["advanced", "advancedns", "needle"]) def test_01_volume_attach(self): """Test Attach volumes (max capacity) """ @@ -202,35 +207,35 @@ class TestAttachVolume(cloudstackTestCase): try: for i in range(self.max_data_volumes): volume = Volume.create( - self.apiclient, - self.services["volume"], - zoneid=self.zone.id, - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["volume"], + zoneid=self.zone.id, + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) # Check List Volume response for newly created volume list_volume_response = Volume.list( - self.apiclient, - id=volume.id - ) + self.apiclient, + id=volume.id + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) # Attach volume to VM self.virtual_machine.attach_volume( - self.apiclient, - volume - ) + self.apiclient, + volume + ) # Check all volumes attached to same VM list_volume_response = Volume.list( - self.apiclient, - virtualmachineid=self.virtual_machine.id, - type='DATADISK', - listall=True - ) + self.apiclient, + virtualmachineid=self.virtual_machine.id, + type='DATADISK', + listall=True + ) self.assertNotEqual( list_volume_response, None, @@ -242,32 +247,34 @@ class TestAttachVolume(cloudstackTestCase): self.assertEqual( len(list_volume_response), self.max_data_volumes, - "Volumes attached to the VM %s. Expected %s" % (len(list_volume_response), self.max_data_volumes)) + "Volumes attached to the VM %s. Expected %s" % + (len(list_volume_response), + self.max_data_volumes)) self.debug("Rebooting the VM: %s" % self.virtual_machine.id) # Reboot VM self.virtual_machine.reboot(self.apiclient) vm_response = VirtualMachine.list( - self.apiclient, - id=self.virtual_machine.id, - ) - #Verify VM response to check whether VM deployment was successful + self.apiclient, + id=self.virtual_machine.id, + ) + # Verify VM response to check whether VM deployment was successful self.assertNotEqual( - len(vm_response), - 0, - "Check VMs available in List VMs response" - ) + len(vm_response), + 0, + "Check VMs available in List VMs response" + ) self.assertEqual( - isinstance(vm_response, list), - True, - "Check list VM response for valid list" - ) + isinstance(vm_response, list), + True, + "Check list VM response for valid list" + ) vm = vm_response[0] self.assertEqual( - vm.state, - 'Running', - "Check the state of VM" - ) + vm.state, + 'Running', + "Check the state of VM" + ) # Stop VM self.virtual_machine.stop(self.apiclient) @@ -278,33 +285,33 @@ class TestAttachVolume(cloudstackTestCase): time.sleep(self.services["sleep"]) vm_response = VirtualMachine.list( - self.apiclient, - id=self.virtual_machine.id, - ) + self.apiclient, + id=self.virtual_machine.id, + ) self.assertEqual( - isinstance(vm_response, list), - True, - "Check list VM response for valid list" - ) + isinstance(vm_response, list), + True, + "Check list VM response for valid list" + ) - #Verify VM response to check whether VM deployment was successful + # Verify VM response to check whether VM deployment was successful self.assertNotEqual( - len(vm_response), - 0, - "Check VMs available in List VMs response" - ) + len(vm_response), + 0, + "Check VMs available in List VMs response" + ) vm = vm_response[0] self.assertEqual( - vm.state, - 'Running', - "Check the state of VM" - ) + vm.state, + 'Running', + "Check the state of VM" + ) except Exception as e: self.fail("Exception occured: %s" % e) return - @attr(tags = ["advanced", "advancedns"]) + @attr(tags=["advanced", "advancedns"]) def test_02_volume_attach_max(self): """Test attach volumes (more than max) to an instance """ @@ -315,22 +322,22 @@ class TestAttachVolume(cloudstackTestCase): # Create a volume and attach to VM volume = Volume.create( - self.apiclient, - self.services["volume"], - zoneid=self.zone.id, - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["volume"], + zoneid=self.zone.id, + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.debug("Created volume: %s for account: %s" % ( - volume.id, - self.account.name - )) + volume.id, + self.account.name + )) # Check List Volume response for newly created volume list_volume_response = Volume.list( - self.apiclient, - id=volume.id - ) + self.apiclient, + id=volume.id + ) self.assertNotEqual( list_volume_response, None, @@ -344,15 +351,16 @@ class TestAttachVolume(cloudstackTestCase): # Attach volume to VM with self.assertRaises(Exception): self.debug("Trying to Attach volume: %s to VM: %s" % ( - volume.id, - self.virtual_machine.id - )) + volume.id, + self.virtual_machine.id + )) self.virtual_machine.attach_volume( - self.apiclient, - volume - ) + self.apiclient, + volume + ) return + class TestAttachDetachVolume(cloudstackTestCase): @classmethod @@ -367,28 +375,28 @@ class TestAttachDetachVolume(cloudstackTestCase): cls.pod = get_pod(cls.api_client, cls.zone.id) cls.services['mode'] = cls.zone.networktype cls.disk_offering = DiskOffering.create( - cls.api_client, - cls.services["disk_offering"] - ) + cls.api_client, + cls.services["disk_offering"] + ) template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id - #get max data volumes limit based on the hypervisor type and version + # get max data volumes limit based on the hypervisor type and version listHost = Host.list( - cls.api_client, - type ='Routing', - zoneid = cls.zone.id, - podid = cls.pod.id, - ) + cls.api_client, + type='Routing', + zoneid=cls.zone.id, + podid=cls.pod.id, + ) ver = listHost[0].hypervisorversion hv = listHost[0].hypervisor cmd = listHypervisorCapabilities.listHypervisorCapabilitiesCmd() - cmd.hypervisor = hv #cls.services["virtual_machine"]["hypervisor"] + cmd.hypervisor = hv # cls.services["virtual_machine"]["hypervisor"] res = cls.api_client.listHypervisorCapabilities(cmd) cls.debug('Hypervisor Capabilities: {}'.format(res)) for i in range(len(res)): @@ -399,28 +407,27 @@ class TestAttachDetachVolume(cloudstackTestCase): cls.services["volume"]["max"] = cls.max_data_volumes # Create VMs, NAT Rules etc cls.account = Account.create( - cls.api_client, - cls.services["account"], - domainid=cls.domain.id - ) - + cls.api_client, + cls.services["account"], + domainid=cls.domain.id + ) cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls.virtual_machine = VirtualMachine.create( - cls.api_client, - cls.services["virtual_machine"], - accountid=cls.account.name, - domainid=cls.account.domainid, - serviceofferingid=cls.service_offering.id, - ) + cls.api_client, + cls.services["virtual_machine"], + accountid=cls.account.name, + domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, + ) cls._cleanup = [ - cls.service_offering, - cls.disk_offering, - cls.account - ] + cls.service_offering, + cls.disk_offering, + cls.account + ] def setUp(self): @@ -429,19 +436,21 @@ class TestAttachDetachVolume(cloudstackTestCase): self.cleanup = [] def tearDown(self): - #Clean up, terminate the created volumes + # Clean up, terminate the created volumes cleanup_resources(self.apiclient, self.cleanup) return @classmethod def tearDownClass(cls): try: - cls.api_client = super(TestAttachDetachVolume, cls).getClsTestClient().getApiClient() + cls.api_client = super( + TestAttachDetachVolume, + cls).getClsTestClient().getApiClient() cleanup_resources(cls.api_client, cls._cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) - @attr(tags = ["advanced", "advancedns"]) + @attr(tags=["advanced", "advancedns"]) def test_01_volume_attach_detach(self): """Test Volume attach/detach to VM (5 data volumes) """ @@ -459,21 +468,21 @@ class TestAttachDetachVolume(cloudstackTestCase): # Create 5 volumes and attach to VM for i in range(self.max_data_volumes): volume = Volume.create( - self.apiclient, - self.services["volume"], - zoneid=self.zone.id, - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["volume"], + zoneid=self.zone.id, + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.cleanup.append(volume) volumes.append(volume) # Check List Volume response for newly created volume list_volume_response = Volume.list( - self.apiclient, - id=volume.id - ) + self.apiclient, + id=volume.id + ) self.assertNotEqual( list_volume_response, None, @@ -484,39 +493,40 @@ class TestAttachDetachVolume(cloudstackTestCase): "Check list volumes response for valid list") # Attach volume to VM self.virtual_machine.attach_volume( - self.apiclient, - volume - ) + self.apiclient, + volume + ) # Check all volumes attached to same VM list_volume_response = Volume.list( - self.apiclient, - virtualmachineid=self.virtual_machine.id, - type='DATADISK', - listall=True - ) + self.apiclient, + virtualmachineid=self.virtual_machine.id, + type='DATADISK', + listall=True + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) self.assertEqual( - isinstance(list_volume_response, list), - True, - "Check list volumes response for valid list" - ) + isinstance(list_volume_response, list), + True, + "Check list volumes response for valid list" + ) self.assertEqual( len(list_volume_response), self.max_data_volumes, - "Volumes attached to the VM %s. Expected %s" % (len(list_volume_response), self.max_data_volumes) - ) + "Volumes attached to the VM %s. Expected %s" % + (len(list_volume_response), + self.max_data_volumes)) # Detach all volumes from VM for volume in volumes: self.virtual_machine.detach_volume( - self.apiclient, - volume - ) + self.apiclient, + volume + ) # Reboot VM self.debug("Rebooting the VM: %s" % self.virtual_machine.id) self.virtual_machine.reboot(self.apiclient) @@ -524,27 +534,27 @@ class TestAttachDetachVolume(cloudstackTestCase): time.sleep(self.services["sleep"]) vm_response = VirtualMachine.list( - self.apiclient, - id=self.virtual_machine.id, - ) - #Verify VM response to check whether VM deployment was successful + self.apiclient, + id=self.virtual_machine.id, + ) + # Verify VM response to check whether VM deployment was successful self.assertEqual( - isinstance(vm_response, list), - True, - "Check list VM response for valid list" - ) + isinstance(vm_response, list), + True, + "Check list VM response for valid list" + ) self.assertNotEqual( - len(vm_response), - 0, - "Check VMs available in List VMs response" - ) + len(vm_response), + 0, + "Check VMs available in List VMs response" + ) vm = vm_response[0] self.assertEqual( - vm.state, - 'Running', - "Check the state of VM" - ) + vm.state, + 'Running', + "Check the state of VM" + ) # Stop VM self.virtual_machine.stop(self.apiclient) @@ -555,26 +565,26 @@ class TestAttachDetachVolume(cloudstackTestCase): time.sleep(self.services["sleep"]) vm_response = VirtualMachine.list( - self.apiclient, - id=self.virtual_machine.id, - ) - #Verify VM response to check whether VM deployment was successful + self.apiclient, + id=self.virtual_machine.id, + ) + # Verify VM response to check whether VM deployment was successful self.assertEqual( - isinstance(vm_response, list), - True, - "Check list VM response for valid list" - ) + isinstance(vm_response, list), + True, + "Check list VM response for valid list" + ) self.assertNotEqual( - len(vm_response), - 0, - "Check VMs available in List VMs response" - ) + len(vm_response), + 0, + "Check VMs available in List VMs response" + ) vm = vm_response[0] self.assertEqual( - vm.state, - 'Running', - "Check the state of VM" - ) + vm.state, + 'Running', + "Check the state of VM" + ) except Exception as e: self.fail("Exception occuered: %s" % e) return @@ -594,25 +604,25 @@ class TestAttachVolumeISO(cloudstackTestCase): cls.pod = get_pod(cls.api_client, cls.zone.id) cls.services['mode'] = cls.zone.networktype cls.disk_offering = DiskOffering.create( - cls.api_client, - cls.services["disk_offering"] - ) + cls.api_client, + cls.services["disk_offering"] + ) template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["iso"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id - #get max data volumes limit based on the hypervisor type and version + # get max data volumes limit based on the hypervisor type and version listHost = Host.list( - cls.api_client, - type ='Routing', - zoneid = cls.zone.id, - podid = cls.pod.id, - ) + cls.api_client, + type='Routing', + zoneid=cls.zone.id, + podid=cls.pod.id, + ) ver = listHost[0].hypervisorversion hv = listHost[0].hypervisor cmd = listHypervisorCapabilities.listHypervisorCapabilitiesCmd() @@ -627,27 +637,27 @@ class TestAttachVolumeISO(cloudstackTestCase): cls.services["volume"]["max"] = cls.max_data_volumes # Create VMs, NAT Rules etc cls.account = Account.create( - cls.api_client, - cls.services["account"], - domainid=cls.domain.id - ) + cls.api_client, + cls.services["account"], + domainid=cls.domain.id + ) cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls.virtual_machine = VirtualMachine.create( - cls.api_client, - cls.services["virtual_machine"], - accountid=cls.account.name, - domainid=cls.account.domainid, - serviceofferingid=cls.service_offering.id, - ) + cls.api_client, + cls.services["virtual_machine"], + accountid=cls.account.name, + domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, + ) cls._cleanup = [ - cls.service_offering, - cls.disk_offering, - cls.account - ] + cls.service_offering, + cls.disk_offering, + cls.account + ] @classmethod def tearDownClass(cls): @@ -664,13 +674,13 @@ class TestAttachVolumeISO(cloudstackTestCase): def tearDown(self): try: - #Clean up, terminate the created instance, volumes and snapshots + # Clean up, terminate the created instance, volumes and snapshots cleanup_resources(self.apiclient, self.cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) return - @attr(tags = ["advanced", "advancedns"]) + @attr(tags=["advanced", "advancedns"]) def test_01_volume_iso_attach(self): """Test Volumes and ISO attach """ @@ -683,84 +693,85 @@ class TestAttachVolumeISO(cloudstackTestCase): # Create 5 volumes and attach to VM for i in range(self.max_data_volumes): volume = Volume.create( - self.apiclient, - self.services["volume"], - zoneid=self.zone.id, - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["volume"], + zoneid=self.zone.id, + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.debug("Created volume: %s for account: %s" % ( - volume.id, - self.account.name - )) + volume.id, + self.account.name + )) # Check List Volume response for newly created volume list_volume_response = Volume.list( - self.apiclient, - id=volume.id - ) + self.apiclient, + id=volume.id + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) self.assertEqual( - isinstance(list_volume_response, list), - True, - "Check list volumes response for valid list" - ) + isinstance(list_volume_response, list), + True, + "Check list volumes response for valid list" + ) # Attach volume to VM self.virtual_machine.attach_volume( - self.apiclient, - volume - ) + self.apiclient, + volume + ) # Check all volumes attached to same VM list_volume_response = Volume.list( - self.apiclient, - virtualmachineid=self.virtual_machine.id, - type='DATADISK', - listall=True - ) + self.apiclient, + virtualmachineid=self.virtual_machine.id, + type='DATADISK', + listall=True + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) self.assertEqual( - isinstance(list_volume_response, list), - True, - "Check list volumes response for valid list" - ) + isinstance(list_volume_response, list), + True, + "Check list volumes response for valid list" + ) self.assertEqual( len(list_volume_response), self.max_data_volumes, - "Volumes attached to the VM %s. Expected %s" % (len(list_volume_response), self.max_data_volumes) - ) + "Volumes attached to the VM %s. Expected %s" % + (len(list_volume_response), + self.max_data_volumes)) # Create an ISO and attach it to VM iso = Iso.create( - self.apiclient, - self.services["iso"], - account=self.account.name, - domainid=self.account.domainid, - ) + self.apiclient, + self.services["iso"], + account=self.account.name, + domainid=self.account.domainid, + ) self.debug("Created ISO with ID: %s for account: %s" % ( - iso.id, - self.account.name - )) + iso.id, + self.account.name + )) try: self.debug("Downloading ISO with ID: %s" % iso.id) iso.download(self.apiclient) except Exception as e: - self.fail("Exception while downloading ISO %s: %s"\ + self.fail("Exception while downloading ISO %s: %s" % (iso.id, e)) - #Attach ISO to virtual machine + # Attach ISO to virtual machine self.debug("Attach ISO ID: %s to VM: %s" % ( - iso.id, - self.virtual_machine.id - )) + iso.id, + self.virtual_machine.id + )) cmd = attachIso.attachIsoCmd() cmd.id = iso.id cmd.virtualmachineid = self.virtual_machine.id @@ -768,27 +779,27 @@ class TestAttachVolumeISO(cloudstackTestCase): # Verify ISO is attached to VM vm_response = VirtualMachine.list( - self.apiclient, - id=self.virtual_machine.id, - ) - #Verify VM response to check whether VM deployment was successful + self.apiclient, + id=self.virtual_machine.id, + ) + # Verify VM response to check whether VM deployment was successful self.assertEqual( - isinstance(vm_response, list), - True, - "Check list VM response for valid list" - ) + isinstance(vm_response, list), + True, + "Check list VM response for valid list" + ) self.assertNotEqual( - len(vm_response), - 0, - "Check VMs available in List VMs response" - ) + len(vm_response), + 0, + "Check VMs available in List VMs response" + ) vm = vm_response[0] self.assertEqual( - vm.isoid, - iso.id, - "Check ISO is attached to VM or not" - ) + vm.isoid, + iso.id, + "Check ISO is attached to VM or not" + ) return @@ -805,52 +816,52 @@ class TestVolumes(cloudstackTestCase): cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) cls.services['mode'] = cls.zone.networktype cls.disk_offering = DiskOffering.create( - cls.api_client, - cls.services["disk_offering"] - ) + cls.api_client, + cls.services["disk_offering"] + ) template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id - cls.services["virtual_machine"]["diskofferingid"] = cls.disk_offering.id + cls.services["virtual_machine"][ + "diskofferingid"] = cls.disk_offering.id # Create VMs, VMs etc cls.account = Account.create( - cls.api_client, - cls.services["account"], - domainid=cls.domain.id - ) - + cls.api_client, + cls.services["account"], + domainid=cls.domain.id + ) cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls.virtual_machine = VirtualMachine.create( - cls.api_client, - cls.services["virtual_machine"], - accountid=cls.account.name, - domainid=cls.account.domainid, - serviceofferingid=cls.service_offering.id, - ) + cls.api_client, + cls.services["virtual_machine"], + accountid=cls.account.name, + domainid=cls.account.domainid, + serviceofferingid=cls.service_offering.id, + ) cls.volume = Volume.create( - cls.api_client, - cls.services["volume"], - zoneid=cls.zone.id, - account=cls.account.name, - domainid=cls.account.domainid, - diskofferingid=cls.disk_offering.id - ) + cls.api_client, + cls.services["volume"], + zoneid=cls.zone.id, + account=cls.account.name, + domainid=cls.account.domainid, + diskofferingid=cls.disk_offering.id + ) cls._cleanup = [ - cls.service_offering, - cls.disk_offering, - cls.account - ] + cls.service_offering, + cls.disk_offering, + cls.account + ] @classmethod def tearDownClass(cls): @@ -865,7 +876,7 @@ class TestVolumes(cloudstackTestCase): self.cleanup = [] def tearDown(self): - #Clean up, terminate the created volumes + # Clean up, terminate the created volumes cleanup_resources(self.apiclient, self.cleanup) return @@ -883,52 +894,52 @@ class TestVolumes(cloudstackTestCase): # Check the list volumes response for vmname and virtualmachineid list_volume_response = Volume.list( - self.apiclient, - id=self.volume.id - ) + self.apiclient, + id=self.volume.id + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) self.assertEqual( - isinstance(list_volume_response, list), - True, - "Check list volumes response for valid list" - ) + isinstance(list_volume_response, list), + True, + "Check list volumes response for valid list" + ) volume = list_volume_response[0] self.assertEqual( - volume.type, - 'DATADISK', - "Check volume type from list volume response" - ) + volume.type, + 'DATADISK', + "Check volume type from list volume response" + ) self.assertEqual( - hasattr(volume, 'vmname'), - True, - "Check whether volume has vmname field" - ) + hasattr(volume, 'vmname'), + True, + "Check whether volume has vmname field" + ) self.assertEqual( - hasattr(volume, 'virtualmachineid'), - True, - "Check whether volume has virtualmachineid field" - ) + hasattr(volume, 'virtualmachineid'), + True, + "Check whether volume has virtualmachineid field" + ) # Attach volume to VM self.debug("Attach volume: %s to VM: %s" % ( - self.volume.id, - self.virtual_machine.id - )) + self.volume.id, + self.virtual_machine.id + )) self.virtual_machine.attach_volume(self.apiclient, self.volume) # Check all volumes attached to same VM list_volume_response = Volume.list( - self.apiclient, - virtualmachineid=self.virtual_machine.id, - type='DATADISK', - listall=True - ) + self.apiclient, + virtualmachineid=self.virtual_machine.id, + type='DATADISK', + listall=True + ) self.assertNotEqual( list_volume_response, None, @@ -941,15 +952,15 @@ class TestVolumes(cloudstackTestCase): ) volume = list_volume_response[0] self.assertEqual( - volume.vmname, - self.virtual_machine.name, - "Check virtual machine name in list volumes response" - ) + volume.vmname, + self.virtual_machine.name, + "Check virtual machine name in list volumes response" + ) self.assertEqual( - volume.virtualmachineid, - self.virtual_machine.id, - "Check VM ID in list Volume response" - ) + volume.virtualmachineid, + self.virtual_machine.id, + "Check VM ID in list Volume response" + ) return @attr(tags=["advanced", "advancedns"], required_hardware="false") @@ -963,40 +974,40 @@ class TestVolumes(cloudstackTestCase): # that volume. self.debug("Detach volume: %s to VM: %s" % ( - self.volume.id, - self.virtual_machine.id - )) + self.volume.id, + self.virtual_machine.id + )) self.virtual_machine.detach_volume(self.apiclient, self.volume) - #Sleep to ensure the current state will reflected in other calls + # Sleep to ensure the current state will reflected in other calls time.sleep(self.services["sleep"]) list_volume_response = Volume.list( - self.apiclient, - id=self.volume.id - ) + self.apiclient, + id=self.volume.id + ) self.assertNotEqual( - list_volume_response, - None, - "Check if volume exists in ListVolumes" - ) + list_volume_response, + None, + "Check if volume exists in ListVolumes" + ) self.assertEqual( - isinstance(list_volume_response, list), - True, - "Check list volumes response for valid list" - ) + isinstance(list_volume_response, list), + True, + "Check list volumes response for valid list" + ) volume = list_volume_response[0] self.assertEqual( - volume.virtualmachineid, - None, - "Check if volume state (detached) is reflected" - ) + volume.virtualmachineid, + None, + "Check if volume state (detached) is reflected" + ) self.assertEqual( - volume.vmname, - None, - "Check if volume state (detached) is reflected" - ) + volume.vmname, + None, + "Check if volume state (detached) is reflected" + ) return @attr(tags=["advanced", "advancedns"], required_hardware="false") @@ -1012,28 +1023,37 @@ class TestVolumes(cloudstackTestCase): cmd.id = self.volume.id self.apiclient.deleteVolume(cmd) - #Sleep to ensure the current state will reflected in other calls + # Sleep to ensure the current state will reflected in other calls time.sleep(self.services["sleep"]) list_volume_response = Volume.list( - self.apiclient, - id=self.volume.id, - ) + self.apiclient, + id=self.volume.id, + ) self.assertEqual( - list_volume_response, - None, - "Volume %s was not deleted" % self.volume.id - ) + list_volume_response, + None, + "Volume %s was not deleted" % self.volume.id + ) return - @attr(tags=["advanced", "advancedns", "simulator", "basic", "eip", "sg"], required_hardware="false") + @attr( + tags=[ + "advanced", + "advancedns", + "simulator", + "basic", + "eip", + "sg"], + required_hardware="false") def test_create_volume_under_domain(self): """Create a volume under a non-root domain as non-root-domain user 1. Create a domain under ROOT 2. Create a user within this domain 3. As user in step 2. create a volume with standard disk offering - 4. Ensure the volume is created in the domain and available to the user in his listVolumes call + 4. Ensure the volume is created in the domain and available to the + user in his listVolumes call """ dom = Domain.create( self.apiclient, @@ -1053,11 +1073,19 @@ class TestVolumes(cloudstackTestCase): self.cleanup.insert(-2, domuser) self.assertTrue(domuser is not None) - domapiclient = self.testClient.getUserApiClient(UserName=domuser.name, DomainName=dom.name) + domapiclient = self.testClient.getUserApiClient( + UserName=domuser.name, + DomainName=dom.name) diskoffering = DiskOffering.list(self.apiclient) - self.assertTrue(isinstance(diskoffering, list), msg="DiskOffering list is not a list?") - self.assertTrue(len(diskoffering) > 0, "no disk offerings in the deployment") + self.assertTrue( + isinstance( + diskoffering, + list), + msg="DiskOffering list is not a list?") + self.assertTrue( + len(diskoffering) > 0, + "no disk offerings in the deployment") vol = Volume.create( domapiclient, @@ -1067,21 +1095,33 @@ class TestVolumes(cloudstackTestCase): domainid=dom.id, diskofferingid=diskoffering[0].id ) - self.assertTrue(vol is not None, "volume creation fails in domain %s as user %s" % (dom.name, domuser.name)) + self.assertTrue( + vol is not None, "volume creation fails in domain %s as user %s" % + (dom.name, domuser.name)) listed_vol = Volume.list(domapiclient, id=vol.id) - self.assertTrue(listed_vol is not None and isinstance(listed_vol, list), - "invalid response from listVolumes for volume %s" % vol.id) - self.assertTrue(listed_vol[0].id == vol.id, - "Volume returned by list volumes %s not matching with queried volume %s in domain %s" % ( - listed_vol[0].id, vol.id, dom.name)) + self.assertTrue( + listed_vol is not None and isinstance( + listed_vol, + list), + "invalid response from listVolumes for volume %s" % + vol.id) + self.assertTrue( + listed_vol[0].id == vol.id, + "Volume returned by list volumes %s not matching with queried\ + volume %s in domain %s" % + (listed_vol[0].id, + vol.id, + dom.name)) class TestDeployVmWithCustomDisk(cloudstackTestCase): @classmethod def setUpClass(cls): - cls.testClient = super(TestDeployVmWithCustomDisk, cls).getClsTestClient() + cls.testClient = super( + TestDeployVmWithCustomDisk, + cls).getClsTestClient() cls.api_client = cls.testClient.getApiClient() cls.services = Services().services # Get Zone, Domain and templates @@ -1089,36 +1129,35 @@ class TestDeployVmWithCustomDisk(cloudstackTestCase): cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) cls.services['mode'] = cls.zone.networktype cls.disk_offering = DiskOffering.create( - cls.api_client, - cls.services["disk_offering"], - custom=True - ) + cls.api_client, + cls.services["disk_offering"], + custom=True + ) template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id # Create VMs, NAT Rules etc cls.account = Account.create( - cls.api_client, - cls.services["account"], - domainid=cls.domain.id - ) - + cls.api_client, + cls.services["account"], + domainid=cls.domain.id + ) cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls._cleanup = [ - cls.service_offering, - cls.disk_offering, - cls.account - ] + cls.service_offering, + cls.disk_offering, + cls.account + ] def setUp(self): @@ -1143,27 +1182,27 @@ class TestDeployVmWithCustomDisk(cloudstackTestCase): # cleanup all created data disks from the account config = Configurations.list( - self.apiclient, - name="custom.diskoffering.size.min" - ) + self.apiclient, + name="custom.diskoffering.size.min" + ) self.assertEqual( isinstance(config, list), True, "custom.diskoffering.size.min should be present in global config" - ) + ) # minimum size of custom disk (in GBs) min_size = int(config[0].value) self.debug("custom.diskoffering.size.min: %s" % min_size) config = Configurations.list( - self.apiclient, - name="custom.diskoffering.size.max" - ) + self.apiclient, + name="custom.diskoffering.size.max" + ) self.assertEqual( isinstance(config, list), True, "custom.diskoffering.size.min should be present in global config" - ) + ) # maximum size of custom disk (in GBs) max_size = int(config[0].value) self.debug("custom.diskoffering.size.max: %s" % max_size) @@ -1173,24 +1212,24 @@ class TestDeployVmWithCustomDisk(cloudstackTestCase): self.services["custom_volume"]["zoneid"] = self.zone.id with self.assertRaises(Exception): Volume.create_custom_disk( - self.apiclient, - self.services["custom_volume"], - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["custom_volume"], + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.debug("Create volume failed!") self.debug("Creating a volume with size more than max cust disk size") self.services["custom_volume"]["customdisksize"] = (max_size + 1) with self.assertRaises(Exception): Volume.create_custom_disk( - self.apiclient, - self.services["custom_volume"], - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["custom_volume"], + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.debug("Create volume failed!") self.debug("Creating a volume with size more than min cust disk " + @@ -1199,17 +1238,18 @@ class TestDeployVmWithCustomDisk(cloudstackTestCase): self.services["custom_volume"]["customdisksize"] = (min_size + 1) try: Volume.create_custom_disk( - self.apiclient, - self.services["custom_volume"], - account=self.account.name, - domainid=self.account.domainid, - diskofferingid=self.disk_offering.id - ) + self.apiclient, + self.services["custom_volume"], + account=self.account.name, + domainid=self.account.domainid, + diskofferingid=self.disk_offering.id + ) self.debug("Create volume of cust disk size succeeded") except Exception as e: self.fail("Create volume failed with exception: %s" % e) return + class TestMigrateVolume(cloudstackTestCase): @classmethod @@ -1234,7 +1274,8 @@ class TestMigrateVolume(cloudstackTestCase): cls.services["zoneid"] = cls.zone.id cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = template.id - cls.services["virtual_machine"]["diskofferingid"] = cls.disk_offering.id + cls.services["virtual_machine"][ + "diskofferingid"] = cls.disk_offering.id # Create VMs, VMs etc cls.account = Account.create( @@ -1255,9 +1296,9 @@ class TestMigrateVolume(cloudstackTestCase): mode=cls.services["mode"] ) cls._cleanup = [ - cls.small_offering, - cls.account - ] + cls.small_offering, + cls.account + ] return @classmethod @@ -1278,13 +1319,15 @@ class TestMigrateVolume(cloudstackTestCase): cleanup_resources(self.apiclient, self.cleanup) return - @attr(tags=["advanced","sg","advancedsg"], required_hardware='true') + @attr(tags=["advanced", "sg", "advancedsg"], required_hardware='true') def test_01_migrateVolume(self): """ - @Desc:Volume is not retaining same uuid when migrating from one storage to another. + @Desc:Volume is not retaining same uuid when migrating from one + storage to another. Step1:Create a volume/data disk Step2:Verify UUID of the volume - Step3:Migrate the volume to another primary storage within the cluster + Step3:Migrate the volume to another primary storage within + the cluster Step4:Migrating volume to new primary storage should succeed Step5:volume UUID should not change even after migration """ @@ -1295,14 +1338,17 @@ class TestMigrateVolume(cloudstackTestCase): zoneid=self.zone.id, account=self.account.name, domainid=self.account.domainid, - ) - self.assertIsNotNone(vol,"Failed to create volume") + ) + self.assertIsNotNone(vol, "Failed to create volume") vol_res = Volume.list( self.apiclient, id=vol.id ) - self.assertEqual(validateList(vol_res)[0],PASS,"Invalid response returned for list volumes") - vol_uuid=vol_res[0].id + self.assertEqual( + validateList(vol_res)[0], + PASS, + "Invalid response returned for list volumes") + vol_uuid = vol_res[0].id try: self.virtual_machine.attach_volume( self.apiclient, @@ -1315,10 +1361,15 @@ class TestMigrateVolume(cloudstackTestCase): id=vol.id ) if not pools: - self.skipTest("No suitable storage pools found for volume migration. Skipping") - self.assertEqual(validateList(pools)[0],PASS,"invalid pool response from findStoragePoolsForMigration") - pool=pools[0] - self.debug("Migrating Volume-ID: %s to Pool: %s" % (vol.id,pool.id)) + self.skipTest( + "No suitable storage pools found for volume migration.\ + Skipping") + self.assertEqual( + validateList(pools)[0], + PASS, + "invalid pool response from findStoragePoolsForMigration") + pool = pools[0] + self.debug("Migrating Volume-ID: %s to Pool: %s" % (vol.id, pool.id)) try: Volume.migrate( self.apiclient, @@ -1334,12 +1385,16 @@ class TestMigrateVolume(cloudstackTestCase): listall='true', type='DATADISK' ) - self.assertEqual(validateList(migrated_vols)[0],PASS,"invalid volumes response after migration") - migrated_vol_uuid=migrated_vols[0].id + self.assertEqual( + validateList(migrated_vols)[0], + PASS, + "invalid volumes response after migration") + migrated_vol_uuid = migrated_vols[0].id self.assertEqual( vol_uuid, migrated_vol_uuid, - "Volume is not retaining same uuid when migrating from one storage to another" + "Volume is not retaining same uuid when migrating from one\ + storage to another" ) self.virtual_machine.detach_volume( self.apiclient,
