nikolauseppinger opened a new pull request, #13583:
URL: https://github.com/apache/cloudstack/pull/13583

   ### Description
   Fixes KVM volume encryption detection on hosts with qemu-img >= 10.1.0.
   
   QEMU changed the `qemu-img --help` supported-formats header from
   "Supported formats:" to "Supported image formats:" in 10.1.0. The detection
   regex in `QemuImg.helpSupportsImageFormat()` no longer matched, so
   `hostSupportsVolumeEncryption()` returned false and `host.volume.encryption`
   was stored as false, blocking encrypted offerings on affected hosts (e.g.
   RHEL 9.8 shipping qemu-img 10.1.0).
   
   The regex now treats the "image" keyword as optional and is covered by unit
   tests for both the legacy and the new header, plus a negative case.
   
   Verified locally: full reactor build of `plugins/hypervisors/kvm` 
(checkstyle,
   compile, testCompile, surefire) via Maven 3.8 / JDK 11 in Docker succeeds, 
and
   a standalone JUnit run exercising `helpSupportsImageFormat()` directly 
against
   both the legacy `Supported formats:` header and the new qemu-img 10.1.0
   `Supported image formats:` header passes (3/3), confirming the fix is
   backward compatible.
   
   ### Types of changes
   - [x] Bug fix (non-breaking change which fixes an issue)
   
   ### Bug Severity
   - [x] Major


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to