Copilot commented on code in PR #12144:
URL: https://github.com/apache/cloudstack/pull/12144#discussion_r3552654700
##########
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##########
@@ -546,6 +546,8 @@ public class ApiConstants {
public static final String SENT_BYTES = "sentbytes";
public static final String SERIAL = "serial";
public static final String SERVICE_IP = "serviceip";
+ public static final String SERVICE_OFFERING_CATEGORY_ID = "categoryid";
+ public static final String SERVICE_OFFERING_CATEGORY_NAME = "categoryname";
Review Comment:
`SERVICE_OFFERING_CATEGORY_NAME` is introduced but never referenced anywhere
in this PR (no parameters or response fields use it). Keeping unused API
constants increases confusion about the intended wire name. Either remove it
until it’s needed, or update the relevant fields/parameters to use it
consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
