Reply that reverting is not supported

Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3690574a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3690574a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3690574a

Branch: refs/heads/hotfix/CLOUDSTACK-7776
Commit: 3690574a2354e309f0181402013a3094263e19b6
Parents: b1ffd88
Author: Mike Tutkowski <mike.tutkow...@solidfire.com>
Authored: Tue Oct 21 11:34:35 2014 -0600
Committer: Mike Tutkowski <mike.tutkow...@solidfire.com>
Committed: Tue Oct 21 16:01:15 2014 -0600

----------------------------------------------------------------------
 .../storage/snapshot/SnapshotStateMachineManagerImpl.java        | 2 +-
 .../storage/snapshot/StorageSystemSnapshotStrategy.java          | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3690574a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
----------------------------------------------------------------------
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
index a70b078..cf5944b 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
@@ -42,7 +42,7 @@ public class SnapshotStateMachineManagerImpl implements 
SnapshotStateMachineMana
         stateMachine.addTransition(Snapshot.State.Creating, 
Event.OperationNotPerformed, Snapshot.State.BackedUp);
         stateMachine.addTransition(Snapshot.State.Creating, 
Event.OperationFailed, Snapshot.State.Error);
         stateMachine.addTransition(Snapshot.State.CreatedOnPrimary, 
Event.BackupToSecondary, Snapshot.State.BackingUp);
-        stateMachine.addTransition(State.CreatedOnPrimary, 
Event.OperationNotPerformed, State.BackedUp);
+        stateMachine.addTransition(Snapshot.State.CreatedOnPrimary, 
Event.OperationNotPerformed, Snapshot.State.BackedUp);
         stateMachine.addTransition(Snapshot.State.BackingUp, 
Event.OperationSucceeded, Snapshot.State.BackedUp);
         stateMachine.addTransition(Snapshot.State.BackingUp, 
Event.OperationFailed, Snapshot.State.Error);
         stateMachine.addTransition(Snapshot.State.BackedUp, 
Event.DestroyRequested, Snapshot.State.Destroying);

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3690574a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
----------------------------------------------------------------------
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
index a36afd3..a0d685f 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
@@ -392,6 +392,10 @@ public class StorageSystemSnapshotStrategy extends 
SnapshotStrategyBase {
 
     @Override
     public StrategyPriority canHandle(Snapshot snapshot, SnapshotOperation op) 
{
+        if (SnapshotOperation.REVERT.equals(op)) {
+            return StrategyPriority.CANT_HANDLE;
+        }
+
         long volumeId = snapshot.getVolumeId();
         VolumeVO volumeVO = _volumeDao.findById(volumeId);
 

Reply via email to