weizhouapache commented on PR #12877: URL: https://github.com/apache/cloudstack/pull/12877#issuecomment-4688739179
> LGTM > > Tested the feature manually. > > The Public and private Templates honor the global setting value of secstorage.public.template.copy.max and secstorage.private.template.copy.max and copies the template to the respective secondary storage. > > validate secstorage.public.template.copy.max at global and zone level Pass > validate secstorage.private.template.copy.max at global and zone level Pass > Validate publlic and private template creation operation from volume Pass > Validate publlic and private template creation operation from a volume snapshot Pass > Validate Upload Template operation from Local Pass > Validate Copy Template operation from one zone to another Pass > Validate Update Template operation from public to private and vice versa Pass great, thanks @kiranchavala @harikrishna-patnala will you review the feature before merge ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
