Pearl1594 commented on code in PR #12617:
URL: https://github.com/apache/cloudstack/pull/12617#discussion_r3389085487
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -1920,6 +2131,15 @@ private SnapshotObjectTO
takeIncrementalVolumeSnapshotOfStoppedVm(SnapshotObject
logger.debug("Taking incremental volume snapshot of volume [{}].
Snapshot will be copied to [{}].", volumeObjectTo,
ObjectUtils.defaultIfNull(secondaryPool, primaryPool));
try {
+ // For CLVM_NG incremental snapshots, validate bitmap before
proceeding
+ /*
+ SnapshotObjectTO bitmapValidationResult =
validateClvmNgBitmapAndFallbackIfNeeded(snapshotObjectTO, primaryPool,
+ secondaryPool, secondaryPoolUrl, snapshotName,
volumeObjectTo, conn, wait);
+ if (bitmapValidationResult != null) {
+ return bitmapValidationResult;
+ }
+ */
Review Comment:
Thanks, will do - I was working on a separate PR to support incremental
snaps for CLVM pool type, but the bitmap solution may not be suitable. So yes,
I'll clean it up. Thanks for the review, much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
