weizhouapache commented on PR #13373: URL: https://github.com/apache/cloudstack/pull/13373#issuecomment-4650405246
> > @sureshanaparti it looks like the change made no effects > > https://github.com/apache/cloudstack/blob/6bc83a3c46f4b51ddf24483ee1fe3ccf65d2791a/core/src/main/java/com/cloud/agent/api/CheckOnHostAnswer.java#L39-L43 > > > > these two lines are the same actually > > ``` > > return new CheckOnHostAnswer(command, "Heart is not beating"); > > return new CheckOnHostAnswer(command, false, "Heart is not beating"); > > ``` > > @weizhouapache answer's success flag is set in the second case (result should be true which indicates the cmd is success, and then get the other details - isAlive, etc), and _answer.getResult()_ is true here: > > https://github.com/apache/cloudstack/blob/21b2025c5055d4580e828f708d406510853f0060/plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kvm/ha/KVMHostActivityChecker.java#L131-L142 ok, I will re-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
