GaOrtiga commented on PR #12615:
URL: https://github.com/apache/cloudstack/pull/12615#issuecomment-4648984193

   @SURYAS1306 @sureshanaparti @DaanHoogland @winterhazel 
   
   As I have mentioned in 
https://github.com/apache/cloudstack/pull/12607#issuecomment-4216054380, this 
doesn't really fix the root cause of the problem, as it leaves inconsistent 
records in the DB.
   
   The actual fix is also much simpler than the proposed solution, only 
requiring 2 line changes: one to prevent this inconsistency from happening in 
the future (which can be achieved by removing the line that equals the `userid` 
parameter to `null` in the `ProjectAccountSearch` search builder on 
`ProjectAccountDaoImpl`), and one to normalize the inconsistent records already 
present on the DB.
   
   What to you guys think of this alternative solution? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to