winterhazel commented on code in PR #13236:
URL: https://github.com/apache/cloudstack/pull/13236#discussion_r3319209541
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementResponse.java:
##########
@@ -31,11 +31,11 @@ public class QuotaStatementResponse extends BaseResponse {
@Param(description = "ID of the Account.")
private String accountId;
- @SerializedName(ApiConstants.ACCOUNT)
+ @SerializedName(ApiConstants.ACCOUNT_NAME)
Review Comment:
@DaanHoogland yes, this is a backwards incompatibility. As a good portion of
the Quota APIs are being worked on this release, I thought it was a good
opportunity to standardize the field naming to match the other APIs. This
change was done considering that:
- There probably are not many people using Quota for billing-related
processes in previous versions due to both lack of flexibility on assigning
values and lack of documentation on how to use the activation rules (the latter
will be addressed in 4.23).
- Either `accountname` + `domainid` or `accountid` must be provided to the
API, so operators already know which account/domain the statement belongs to.
Therefore, I find it unlikely that external integrations rely on this field.
The UI does not use it either.
- As the Quota plugin is planned to receive in this release lots of new
functionality that will make it more reliable for external integrations, I
expect that existing integrations will be updated. And just renaming a field
from the response is a very simple update.
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementResponse.java:
##########
@@ -31,11 +31,11 @@ public class QuotaStatementResponse extends BaseResponse {
@Param(description = "ID of the Account.")
private String accountId;
- @SerializedName(ApiConstants.ACCOUNT)
+ @SerializedName(ApiConstants.ACCOUNT_NAME)
@Param(description = "Name of the Account.")
private String accountName;
- @SerializedName(ApiConstants.DOMAIN)
+ @SerializedName(ApiConstants.DOMAIN_ID)
Review Comment:
See https://github.com/apache/cloudstack/pull/13236#discussion_r3319209541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
