andrijapanicsb opened a new pull request, #13270: URL: https://github.com/apache/cloudstack/pull/13270
### Description This PR expands VMware-to-KVM import using VDDK so converted VMs can target Ceph RBD storage. The change adds two supported RBD paths: - direct VDDK-to-RBD import when `usevddk=true`, `forceconverttopool=true`, the source VM is powered off, and the selected KVM conversion host supports VDDK, `qemu-img` RBD access, and in-place `virt-v2v` finalisation - staged import where conversion still uses temporary shared storage and final disks can be copied into RBD when the import host supports qemu-based RBD copy access Main behaviour changes: - advertises and persists KVM host capability details for VDDK RBD direct import, in-place virt-v2v, qemu-img RBD support, and RBD qemu copy support - validates direct RBD VDDK imports during host selection and conversion pre-checks - propagates VMware VM MoRef and source disk metadata from discovery to the KVM conversion command - adds direct RBD conversion flow using `nbdkit` VDDK source reads, `qemu-img convert` into RBD, and `virt-v2v` in-place finalisation - allows RBD destination pools for the VDDK `forceconverttopool` flow while retaining the existing OVF restrictions - teaches converted-instance import to use the actual destination pool type instead of assuming NFS <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A ### How Has This Been Tested? Ran the focused compile/test checks below: ```text git diff --check mvn -pl api,core -am -DskipTests "-Dcheckstyle.skip=true" compile mvn -pl engine/orchestration -am -DskipTests "-Dcheckstyle.skip=true" compile mvn -pl plugins/hypervisors/kvm -am -DskipTests "-Dcheckstyle.skip=true" compile mvn -pl plugins/hypervisors/kvm -am "-Dtest=LibvirtCheckConvertInstanceCommandWrapperTest,LibvirtConvertInstanceCommandWrapperTest,LibvirtImportConvertedInstanceCommandWrapperTest" -DfailIfNoTests=false "-Dsurefire.failIfNoSpecifiedTests=false" test mvn -pl plugins/hypervisors/kvm -am "-Dtest=LibvirtConvertInstanceCommandWrapperTest" -DfailIfNoTests=false "-Dsurefire.failIfNoSpecifiedTests=false" test mvn -pl server -am "-Dtest=UnmanagedVMsManagerImplTest#testValidateSelectedConversionStoragePoolForVddkSkipsTemporaryPoolForStagedImport+testSelectKVMHostForConversionInClusterDirectRbdAutoSelectsHostWithDirectSupport+testSelectKVMHostForConversionInClusterDirectRbdFailsWithoutDirectSupport+testCheckConversionStoragePoolRbdAllowedForVddkForceConvertToPool" -DfailIfNoTests=false "-Dsurefire.failIfNoSpecifiedTests=false" test ``` The new tests cover direct RBD host capability success/failure checks, direct RBD conversion rejection when host capability is missing, RBD destination pool handling during import, RBD disk metadata generation, staged RBD host support validation, and server-side RBD storage pool validation. #### How did you try to break this feature and the system with this change? Added negative tests for hosts without direct VDDK/RBD support and ensured staged RBD imports require qemu-based RBD copy support. Also kept existing non-RBD paths compatible by preserving old command constructors and defaulting old import logic to NFS destination behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
