(cloudstack) branch 4.20 updated: Fix the validation of CPVMs states in multiple zones (#13021)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

DaanHoogland pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.20 by this push:
     new b642bbe38e1 Fix the validation of CPVMs states in multiple zones 
(#13021)
b642bbe38e1 is described below

commit b642bbe38e132481906a65f5f73ada177aea8e00
Author: Tonitzpp <134986282+tonit...@users.noreply.github.com>
AuthorDate: Wed May 27 08:36:31 2026 -0300

    Fix the validation of CPVMs states in multiple zones (#13021)
    
    Co-authored-by: Toni Zamparetti <toni.zampare...@scclouds.com.br>
    Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2...@gmail.com>
---
 .../java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java     | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 
b/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
index 3d834af7a86..f1e422ec36c 100644
--- a/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
+++ b/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
@@ -1525,12 +1525,9 @@ public class ConsoleProxyManagerImpl extends ManagerBase 
implements ConsoleProxy
             return false;
         }
 
-        List<ConsoleProxyVO> l = 
consoleProxyDao.getProxyListInStates(State.Starting, State.Stopping);
-        if (l.size() > 0) {
-            if (logger.isDebugEnabled()) {
-                logger.debug("Zone {} has {} console proxy VM(s) in transition 
state", zone, l.size());
-            }
-
+        List<ConsoleProxyVO> consoleProxiesInTransitionStates = 
consoleProxyDao.getProxyListInStates(dataCenterId, State.Starting, 
State.Stopping);
+        if (!consoleProxiesInTransitionStates.isEmpty()) {
+            logger.debug("Zone {} has {} console proxy VM(s) in transition 
state.", zone, consoleProxiesInTransitionStates.size());
             return false;
         }