andrijapanicsb opened a new pull request, #13235: URL: https://github.com/apache/cloudstack/pull/13235
## Description This improves the VMware import workflow when `forceconverttopool=true` and the caller does not provide `convertinstancepoolid`. Previously, the API always failed in that case, even when the destination environment had exactly one suitable primary storage pool. With this change, CloudStack infers that single suitable pool and proceeds. If no suitable pool exists, or if multiple suitable pools exist, the API still fails with a clear message so the caller can provide `convertinstancepoolid` explicitly. No API parameters are added or removed. ## API behavior When `forceconverttopool=true`: - If `convertinstancepoolid` is supplied, the selected pool is used and validated as before. - If `convertinstancepoolid` is omitted and exactly one suitable KVM primary storage pool exists for the destination cluster or zone, that pool is used automatically. - If no suitable pool exists, the request fails with a clear error. - If multiple suitable pools exist, the request fails and asks the caller to provide `convertinstancepoolid`. ## UI behavior - Direct conversion opens the primary storage selection path. - If the returned storage-pool list contains exactly one pool, the UI selects it automatically. - If multiple pools are available, the operator still chooses the intended pool. ## Testing - `mvn -pl server -am -Dtest=UnmanagedVMsManagerImplTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
