nvazquez commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3213384911


##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportVmCmd.java:
##########
@@ -255,6 +263,10 @@ public Long getStoragePoolId() {
         return storagePoolId;
     }
 
+    public boolean getUseVddk() {
+        return BooleanUtils.toBooleanDefaultIfNull(useVddk, true);

Review Comment:
   @harikrishna-patnala @rajujith IMO the default value of this boolean should 
be false. I'm not able to migrate VMs without VDDK installed anymore
   
   ````
   2026-05-09 15:51:17,643 ERROR [o.a.c.v.UnmanagedVMsManagerImpl] 
(API-Job-Executor-1:[ctx-961baab4, job-251, ctx-757448a4]) (logid:fd8b0e9d) The 
h
   ost Host 
{"id":1,"name":"ref-trl-11356-k-Mr9-nicolas-vazquez-kvm1","type":"Routing","uuid":"00504c23-253a-4c33-8268-1ba6c70aa837"}
 doesn't suppor
   t conversion of instance i-2-5-VM from VMware to KVM due to: Cannot convert 
the instance from VMware using VDDK on host 10.0.32.227. Please make 
   sure virt-v2v, nbdkit-vddk and a valid VDDK library directory are available 
on the host.
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to