Kunalbehbud commented on PR #13020: URL: https://github.com/apache/cloudstack/pull/13020#issuecomment-4373154768
Thanks for testing it. You were right, the validation was happening before the VM snapshot left `Allocated`, so the failure path could not move it to `Error`. I pushed `414d9c1` to move the create transition before host capability validation. The unsupported-host case still fails before any agent command is sent, but now the VM snapshot can be marked failed instead of being left in `Allocated`. I also added a regression test for that path. Local verification: `mvn -pl engine/orchestration,engine/storage/snapshot,plugins/hypervisors/kvm -am -Dtest=AgentManagerImplTest,KvmFileBasedStorageVmSnapshotStrategyTest,LibvirtDiskOnlyVMSnapshotCommandWrapperTest -Dsurefire.failIfNoSpecifiedTests=false test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
