Repository: cloudstack Updated Branches: refs/heads/master 03e3a39ed -> f4ef83630
CLOUDSTACK-7617: Removed hard coded VM names and skipped test cases according to the hypervisor support Signed-off-by: SrikanteswaraRao Talluri <tall...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f4ef8363 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f4ef8363 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f4ef8363 Branch: refs/heads/master Commit: f4ef8363093c289bea09a2c5a81a49641b601c8d Parents: 03e3a39 Author: Gaurav Aradhye <gaurav.arad...@clogeny.com> Authored: Wed Sep 24 16:05:14 2014 +0530 Committer: SrikanteswaraRao Talluri <tall...@apache.org> Committed: Fri Sep 26 12:09:07 2014 +0530 ---------------------------------------------------------------------- .../component/test_custom_hostname.py | 915 +++++++++++-------- 1 file changed, 511 insertions(+), 404 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f4ef8363/test/integration/component/test_custom_hostname.py ---------------------------------------------------------------------- diff --git a/test/integration/component/test_custom_hostname.py b/test/integration/component/test_custom_hostname.py index 9d9008a..fcd497e 100644 --- a/test/integration/component/test_custom_hostname.py +++ b/test/integration/component/test_custom_hostname.py @@ -16,12 +16,13 @@ # under the License. """ P1 tests for user provide hostname cases """ -#Import Local Modules +# Import Local Modules from nose.plugins.attrib import attr -from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.cloudstackTestCase import cloudstackTestCase, unittest from marvin.lib.utils import (cleanup_resources, - random_gen) + random_gen, + get_hypervisor_type) from marvin.lib.base import (ServiceOffering, Configurations, VirtualMachine, @@ -30,133 +31,143 @@ from marvin.lib.common import (get_domain, get_zone, get_template, is_config_suitable) +import string class Services: + """Test user provided hostname Services """ def __init__(self): self.services = { - "domain": { - "name": "Domain", - }, - "project": { - "name": "Project", - "displaytext": "Test project", - }, - "account": { - "email": "administra...@clogeny.com", - "firstname": "Test", - "lastname": "User", - "username": "test", - # Random characters are appended for unique - # username - "password": "password", - }, - "account_2": { - "email": "administrat...@clogeny.com", - "firstname": "Test1", - "lastname": "User1", - "username": "test1", - # Random characters are appended for unique - # username - "password": "password", - }, - "user": { - "email": "administra...@clogeny.com", - "firstname": "User", - "lastname": "User", - "username": "User", - # Random characters are appended for unique - # username - "password": "password", - }, - "disk_offering": { - "displaytext": "Tiny Disk Offering", - "name": "Tiny Disk Offering", - "disksize": 1 - }, - "volume": { - "diskname": "Test Volume", - }, - "service_offering": { - "name": "Tiny Instance", - "displaytext": "Tiny Instance", - "cpunumber": 1, - "cpuspeed": 100, # in MHz - "memory": 128, # In MBs - }, - "virtual_machine": { - "displayname": "TestVM", - "username": "root", - "password": "password", - "ssh_port": 22, - "hypervisor": 'XenServer', - # Hypervisor type should be same as - # hypervisor type of cluster - "privateport": 22, - "publicport": 22, - "protocol": 'TCP', - }, - "virtual_machine2": { - "displayname": "TestVM", - "username": "root", - "password": "password", - "ssh_port": 22, - "hypervisor": 'XenServer', - # Hypervisor type should be same as - # hypervisor type of cluster - "privateport": 22, - "publicport": 22, - "protocol": 'TCP', - }, - "ostype": 'CentOS 5.3 (64-bit)', - # Cent OS 5.3 (64 bit) - "sleep": 60, - "timeout": 10, - } + "domain": { + "name": "Domain", + }, + "project": { + "name": "Project", + "displaytext": "Test project", + }, + "account": { + "email": "administra...@clogeny.com", + "firstname": "Test", + "lastname": "User", + "username": "test", + # Random characters are appended for unique + # username + "password": "password", + }, + "account_2": { + "email": "administrat...@clogeny.com", + "firstname": "Test1", + "lastname": "User1", + "username": "test1", + # Random characters are appended for unique + # username + "password": "password", + }, + "user": { + "email": "administra...@clogeny.com", + "firstname": "User", + "lastname": "User", + "username": "User", + # Random characters are appended for unique + # username + "password": "password", + }, + "disk_offering": { + "displaytext": "Tiny Disk Offering", + "name": "Tiny Disk Offering", + "disksize": 1 + }, + "volume": { + "diskname": "Test Volume", + }, + "service_offering": { + "name": "Tiny Instance", + "displaytext": "Tiny Instance", + "cpunumber": 1, + "cpuspeed": 100, # in MHz + "memory": 128, # In MBs + }, + "virtual_machine": { + "displayname": "", + "username": "root", + "password": "password", + "ssh_port": 22, + "hypervisor": 'XenServer', + # Hypervisor type should be same as + # hypervisor type of cluster + "privateport": 22, + "publicport": 22, + "protocol": 'TCP', + }, + "virtual_machine2": { + "displayname": "", + "username": "root", + "password": "password", + "ssh_port": 22, + "hypervisor": 'XenServer', + # Hypervisor type should be same as + # hypervisor type of cluster + "privateport": 22, + "publicport": 22, + "protocol": 'TCP', + }, + "ostype": 'CentOS 5.3 (64-bit)', + # Cent OS 5.3 (64 bit) + "sleep": 60, + "timeout": 10, + } class TestInstanceNameFlagTrue(cloudstackTestCase): @classmethod def setUpClass(cls): - cls.testClient = super(TestInstanceNameFlagTrue, cls).getClsTestClient() + cls.testClient = super( + TestInstanceNameFlagTrue, + cls).getClsTestClient() cls.api_client = cls.testClient.getApiClient() + cls.hypervisor = (get_hypervisor_type(cls.api_client)).lower() + if cls.hypervisor != "vmware": + raise unittest.SkipTest("Instance name configuration value\ + is effective only on vmware hypervisor") + cls.services = Services().services # Get Zone, Domain and templates cls.domain = get_domain(cls.api_client) - cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) + cls.zone = get_zone(cls.api_client, + cls.testClient.getZoneForTests()) cls.services["mode"] = cls.zone.networktype cls.template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) # Create account cls.account = Account.create( - cls.api_client, - cls.services["account"], - admin=True, - domainid=cls.domain.id - ) + cls.api_client, + cls.services["account"], + admin=True, + domainid=cls.domain.id + ) cls.account_2 = Account.create( - cls.api_client, - cls.services["account_2"], - admin=True, - domainid=cls.domain.id - ) + cls.api_client, + cls.services["account_2"], + admin=True, + domainid=cls.domain.id + ) cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = cls.template.id cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls._cleanup = [cls.account, cls.account_2] return @@ -164,7 +175,7 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): @classmethod def tearDownClass(cls): try: - #Cleanup resources used + # Cleanup resources used cleanup_resources(cls.api_client, cls._cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) @@ -173,20 +184,30 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): def setUp(self): self.apiclient = self.testClient.getApiClient() self.dbclient = self.testClient.getDbConnection() + + self.services["virtual_machine"]["name"] =\ + random_gen(chars=string.ascii_uppercase) self.cleanup = [] return def tearDown(self): try: - #Clean up, terminate the created accounts, domains etc + # Clean up, terminate the created accounts, domains etc cleanup_resources(self.apiclient, self.cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) return - @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_01_user_provided_hostname(self): """ Verify user provided hostname to an instance """ @@ -196,106 +217,112 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): # should be user provided display name # 2. Give the user provided user name. Internal name should be # i-<userid>-<vmid>-display name - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='true'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='true'): self.skipTest('vm.instancename.flag should be true. skipping') self.debug("Deploying VM in account: %s" % self.account.name) # Spawn an instance in that network + self.services["virtual_machine"]["displayname"] = random_gen( + chars=string.ascii_uppercase) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should return a valid name" - ) + isinstance(vms, list), + True, + "List vms should return a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.debug("vm.displayname: %s, original: %s" % - (vm.displayname, - self.services["virtual_machine"]["displayname"])) + (vm.displayname, + self.services["virtual_machine"]["displayname"])) self.assertEqual( - vm.displayname, - self.services["virtual_machine"]["displayname"], - "Vm display name should match the given name" - ) + vm.displayname, + self.services["virtual_machine"]["displayname"], + "Vm display name should match the given name" + ) # Fetch account ID and VMID from database to check internal name - self.debug("select id from account where uuid = '%s';" \ - % self.account.id) + self.debug("select id from account where uuid = '%s';" + % self.account.id) qresultset = self.dbclient.execute( - "select id from account where uuid = '%s';" \ - % self.account.id - ) + "select id from account where uuid = '%s';" + % self.account.id + ) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] account_id = qresult[0] self.debug("select id from vm_instance where uuid = '%s';" % vm.id) qresultset = self.dbclient.execute( - "select id from vm_instance where uuid = '%s';" % - vm.id) + "select id from vm_instance where uuid = '%s';" % + vm.id) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] self.debug("Query result: %s" % qresult) vmid = qresult[0] self.debug("Fetching the global config value for instance.name") configs = Configurations.list( - self.apiclient, - name="instance.name", - listall=True - ) + self.apiclient, + name="instance.name", + listall=True + ) config = configs[0] instance_name = config.value - #internal Name = i-<user ID>-<VM ID>-instance.name flag value - internal_name = "i-" + str(account_id) + "-" + str(vmid) + "-" + instance_name + # internal Name = i-<user ID>-<VM ID>-instance.name flag value + internal_name = "i-" + \ + str(account_id) + "-" + str(vmid) + "-" + instance_name self.assertEqual( - vm.instancename, - internal_name, - "VM internal name should match with that of the format" - ) + vm.instancename, + internal_name, + "VM internal name should match with that of the format" + ) return @attr(tags=["advanced", "basic", "test"]) @@ -303,19 +330,25 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): @attr(configuration='vm.instancename.flag') def test_vm_instance_name_duplicate_different_accounts(self): """ - @Desc: Test whether cloudstack allows duplicate vm instance names in the diff networks + @Desc: Test whether cloudstack allows duplicate vm instance + names in the diff networks @Steps: Step1: Set the vm.instancename.flag to true. - Step2: Deploy a VM with name say webserver01 from account1 Internal name should be i-<userid>-<vmid>-webserver01 + Step2: Deploy a VM with name say webserver01 from account1 + Internal name should be i-<userid>-<vmid>-webserver01 Step3: Now deploy VM with the same name "webserver01" from account2. Step4: Deployment of VM with same name should fail """ - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='true'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='true'): self.skipTest('vm.instancename.flag should be true. skipping') # Step2: Deploy a VM with name say webserver01 from account1 self.debug("Deploying VM in account: %s" % self.account.name) - self.services["virtual_machine2"]["displayname"] = "webserver01" + self.services["virtual_machine2"][ + "displayname"] = random_gen(chars=string.ascii_uppercase) self.services["virtual_machine2"]["zoneid"] = self.zone.id self.services["virtual_machine2"]["template"] = self.template.id vm1 = VirtualMachine.create( @@ -324,7 +357,7 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): accountid=self.account.name, domainid=self.account.domainid, serviceofferingid=self.service_offering.id, - ) + ) self.cleanup.append(vm1) # Step3: Now deploy VM with the same name "webserver01" from account2. @@ -336,13 +369,21 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): accountid=self.account_2.name, domainid=self.account_2.domainid, serviceofferingid=self.service_offering.id, - ) + ) self.cleanup.append(vm2) # Step4: Deployment of VM with same name should fail return @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_02_instancename_from_default_configuration(self): """ Verify for globally set instancename """ @@ -352,108 +393,120 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): # should be user provided display name # 2. Dont give the user provided user name. Internal name should be # i-<userid>-<vmid>-<instance.name> in global config - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='true'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='true'): self.skipTest('vm.instancename.flag should be true. skipping') # Removing display name from config del self.services["virtual_machine"]["displayname"] self.debug("Deploying VM in account: %s" % self.account.name) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.assertNotEqual( - vm.displayname, - vm.id, - "Vm display name should not match the given name" - ) + vm.displayname, + vm.id, + "Vm display name should not match the given name" + ) # Fetch account ID and VMID from database to check internal name - self.debug("select id from account where uuid = '%s';" \ - % self.account.id) + self.debug("select id from account where uuid = '%s';" + % self.account.id) qresultset = self.dbclient.execute( - "select id from account where uuid = '%s';" \ - % self.account.id - ) + "select id from account where uuid = '%s';" + % self.account.id + ) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] account_id = qresult[0] self.debug("select id from vm_instance where uuid = '%s';" % vm.id) qresultset = self.dbclient.execute( - "select id from vm_instance where uuid = '%s';" % - vm.id) + "select id from vm_instance where uuid = '%s';" % + vm.id) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] self.debug("Query result: %s" % qresult) vmid = qresult[0] self.debug("Fetching the global config value for instance.name") configs = Configurations.list( - self.apiclient, - name="instance.name", - listall=True - ) + self.apiclient, + name="instance.name", + listall=True + ) config = configs[0] instance_name = config.value self.debug("Instance.name: %s" % instance_name) - #internal Name = i-<user ID>-<VM ID>- Instance_name - internal_name = "i-" + str(account_id) + "-" + str(vmid) + "-" + instance_name + # internal Name = i-<user ID>-<VM ID>- Instance_name + internal_name = "i-" + \ + str(account_id) + "-" + str(vmid) + "-" + instance_name self.assertEqual( - vm.instancename, - internal_name, - "VM internal name should match with that of the format" - ) + vm.instancename, + internal_name, + "VM internal name should match with that of the format" + ) return @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_03_duplicate_name(self): """ Test the duplicate name when old VM is in non-expunged state """ @@ -465,56 +518,67 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): # out saying the duplicate names are not allowed # Reading display name property - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='true'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='true'): self.skipTest('vm.instancename.flag should be true. skipping') - self.services["virtual_machine"]["displayname"] = "TestVM" - self.services["virtual_machine"]["name"] = "TestVM" + self.services["virtual_machine"]["displayname"] = random_gen( + chars=string.ascii_uppercase) self.debug("Deploying an instance in account: %s" % - self.account.name) + self.account.name) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.cleanup.append(virtual_machine) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.debug("Display name: %s" % vm.displayname) self.debug("Deplying another virtual machine with same name") with self.assertRaises(Exception): VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) return @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_instance_name_with_hyphens(self): """ Test the instance name with hyphens """ @@ -524,46 +588,58 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): # 2. Add the virtual machine with display name with hyphens # Reading display name property - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='true'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='true'): self.skipTest('vm.instancename.flag should be true. skipping') - self.services["virtual_machine"]["displayname"] = "TestVM-test-name" + self.services["virtual_machine"]["displayname"] = random_gen( + chars=string.ascii_uppercase) + "-" + random_gen( + chars=string.ascii_uppercase) self.debug("Deploying an instance in account: %s" % - self.account.name) + self.account.name) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.debug("Display name: %s" % vm.displayname) return - @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_04_edit_display_name(self): """ Test Edit the Display name Through the UI. """ @@ -576,41 +652,40 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): # internal name will not be changed. The VM functionality must not # be effected. - self.services["virtual_machine"]["name"] = "TestVM4" # Spawn an instance in that network self.debug("Deploying VM in account: %s" % self.account.name) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.assertEqual( - vm.displayname, - self.services["virtual_machine"]["displayname"], - "Vm display name should match the given name" - ) + vm.displayname, + self.services["virtual_machine"]["displayname"], + "Vm display name should match the given name" + ) old_internal_name = vm.instancename self.debug("Stopping the instance: %s" % vm.name) @@ -621,42 +696,53 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): self.debug("Update the display name of the instance") try: - virtual_machine.update(self.apiclient, displayname=random_gen()) + virtual_machine.update( + self.apiclient, + displayname=random_gen( + chars=string.ascii_uppercase)) except Exception as e: self.fail("Failed to update the virtual machine name: %s, %s" % - (virtual_machine.name, e)) + (virtual_machine.name, e)) self.debug("Start the instance: %s" % virtual_machine.name) virtual_machine.start(self.apiclient) self.debug("Checking if the instance is working properly after update") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.assertEqual( - vm.instancename, - old_internal_name, - "Vm internal name should not be changed after update" - ) + vm.instancename, + old_internal_name, + "Vm internal name should not be changed after update" + ) return @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_05_unsupported_chars_in_display_name(self): """ Test Unsupported chars in the display name (eg: Spaces,Exclamation,yet to get unsupported chars from the dev) @@ -675,16 +761,18 @@ class TestInstanceNameFlagTrue(cloudstackTestCase): for display_name in display_names: self.debug("Display name: %s" % display_name) self.services["virtual_machine"]["displayname"] = display_name + self.services["virtual_machine"]["name"] = random_gen( + chars=string.ascii_uppercase) with self.assertRaises(Exception): # Spawn an instance in that network VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) return @@ -692,42 +780,45 @@ class TestInstanceNameFlagFalse(cloudstackTestCase): @classmethod def setUpClass(cls): - cls.testClient = super(TestInstanceNameFlagFalse, cls).getClsTestClient() + cls.testClient = super( + TestInstanceNameFlagFalse, + cls).getClsTestClient() cls.api_client = cls.testClient.getApiClient() cls.services = Services().services # Get Zone, Domain and templates cls.domain = get_domain(cls.api_client) - cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) + cls.zone = get_zone(cls.api_client, + cls.testClient.getZoneForTests()) cls.template = get_template( - cls.api_client, - cls.zone.id, - cls.services["ostype"] - ) + cls.api_client, + cls.zone.id, + cls.services["ostype"] + ) # Create account cls.account = Account.create( - cls.api_client, - cls.services["account"], - admin=True, - domainid=cls.domain.id - ) + cls.api_client, + cls.services["account"], + admin=True, + domainid=cls.domain.id + ) cls.services["virtual_machine"]["zoneid"] = cls.zone.id cls.services["virtual_machine"]["template"] = cls.template.id cls.service_offering = ServiceOffering.create( - cls.api_client, - cls.services["service_offering"] - ) + cls.api_client, + cls.services["service_offering"] + ) cls._cleanup = [cls.account] return @classmethod def tearDownClass(cls): try: - #Cleanup resources used + # Cleanup resources used cleanup_resources(cls.api_client, cls._cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) @@ -741,14 +832,22 @@ class TestInstanceNameFlagFalse(cloudstackTestCase): def tearDown(self): try: - #Clean up, terminate the created accounts, domains etc + # Clean up, terminate the created accounts, domains etc cleanup_resources(self.apiclient, self.cleanup) except Exception as e: raise Exception("Warning: Exception during cleanup : %s" % e) return @attr(configuration='vm.instancename.flag') - @attr(tags=["advanced", "basic", "sg", "eip", "advancedns", "simulator"], required_hardware="false") + @attr( + tags=[ + "advanced", + "basic", + "sg", + "eip", + "advancedns", + "simulator"], + required_hardware="false") def test_01_custom_hostname_instancename_false(self): """ Verify custom hostname for the instance when vm.instancename.flag=false @@ -758,111 +857,119 @@ class TestInstanceNameFlagFalse(cloudstackTestCase): # 1. Set the vm.instancename.flog to false. Hostname and displayname # should be UUID # 2. Give the user provided display name. Internal name should be - # i-<userid>-<vmid>-instance name (It should not contain display name) + # i-<userid>-<vmid>-instance name (It should not contain display name) - if not is_config_suitable(apiclient=self.apiclient, name='vm.instancename.flag', value='false'): + if not is_config_suitable( + apiclient=self.apiclient, + name='vm.instancename.flag', + value='false'): self.skipTest('vm.instancename.flag should be false. skipping') self.debug("Deploying VM in account: %s" % self.account.name) # Spawn an instance in that network + self.services["virtual_machine"]["displayname"] = random_gen( + chars=string.ascii_uppercase) virtual_machine = VirtualMachine.create( - self.apiclient, - self.services["virtual_machine"], - accountid=self.account.name, - domainid=self.account.domainid, - serviceofferingid=self.service_offering.id, - ) + self.apiclient, + self.services["virtual_machine"], + accountid=self.account.name, + domainid=self.account.domainid, + serviceofferingid=self.service_offering.id, + ) self.debug( "Checking if the virtual machine is created properly or not?") vms = VirtualMachine.list( - self.apiclient, - id=virtual_machine.id, - listall=True - ) + self.apiclient, + id=virtual_machine.id, + listall=True + ) self.assertEqual( - isinstance(vms, list), - True, - "List vms should retuen a valid name" - ) + isinstance(vms, list), + True, + "List vms should retuen a valid name" + ) vm = vms[0] self.assertEqual( - vm.state, - "Running", - "Vm state should be running after deployment" - ) + vm.state, + "Running", + "Vm state should be running after deployment" + ) self.debug("vm.displayname: %s, original: %s" % - (vm.displayname, - self.services["virtual_machine"]["displayname"])) + (vm.displayname, + self.services["virtual_machine"]["displayname"])) self.assertEqual( - vm.displayname, - self.services["virtual_machine"]["displayname"], - "Vm display name should match the given name" - ) + vm.displayname, + self.services["virtual_machine"]["displayname"], + "Vm display name should match the given name" + ) # Fetch account ID and VMID from database to check internal name - self.debug("select id from account where uuid = '%s';" \ - % self.account.id) + self.debug("select id from account where uuid = '%s';" + % self.account.id) qresultset = self.dbclient.execute( - "select id from account where uuid = '%s';" \ - % self.account.id - ) + "select id from account where uuid = '%s';" + % self.account.id + ) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] account_id = qresult[0] self.debug("select id from vm_instance where uuid = '%s';" % vm.id) qresultset = self.dbclient.execute( - "select id from vm_instance where uuid = '%s';" % - vm.id) + "select id from vm_instance where uuid = '%s';" % + vm.id) self.assertEqual( - isinstance(qresultset, list), - True, - "Check DB query result set for valid data" - ) + isinstance(qresultset, list), + True, + "Check DB query result set for valid data" + ) self.assertNotEqual( - len(qresultset), - 0, - "Check DB Query result set" - ) + len(qresultset), + 0, + "Check DB Query result set" + ) qresult = qresultset[0] self.debug("Query result: %s" % qresult) vmid = qresult[0] self.debug("Fetching the global config value for instance.name") configs = Configurations.list( - self.apiclient, - name="instance.name", - listall=True - ) + self.apiclient, + name="instance.name", + listall=True + ) config = configs[0] - self.debug("Config value : %s" % config) + self.debug("Config value : %s" % config) instance_name = config.value self.debug("Instance.name: %s" % instance_name) - #internal Name = i-<user ID>-<VM ID>-<instance_name> - #internal_name = "i-" + str(account_id) + "-" + str(vmid) + "-" + instance_name - internal_name = "i-%s-%s-%s" %(str(account_id), str(vmid), instance_name) + # internal Name = i-<user ID>-<VM ID>-<instance_name> + # internal_name = "i-" + str(account_id) + "-" + str(vmid) + "-" + + # instance_name + internal_name = "i-%s-%s-%s" % (str(account_id), + str(vmid), + instance_name) self.debug("Internal name: %s" % internal_name) self.debug("vm instance name : %s" % vm.instancename) self.assertEqual( - vm.instancename, - internal_name, - "VM internal name should match with that of the format" - ) + vm.instancename, + internal_name, + "VM internal name should match with that of the format" + ) return
