DaanHoogland commented on code in PR #12859:
URL: https://github.com/apache/cloudstack/pull/12859#discussion_r3087472691
##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -584,6 +584,37 @@ def fw_vpcrouter(self):
"-A PREROUTING -m state --state NEW -i %s -s
%s ! -d %s/32 -j ACL_OUTBOUND_%s" %
(self.dev, guestNetworkCidr,
self.address['gateway'], self.dev)])
+ # Process static routes for this interface
Review Comment:
I feel strongly but that is not absolute. I don’t think you should force
yourself or that it is a requirement for merging (at all) or that you should do
it if you feel it is a risk. I do think that such extractions make code more
readable and maintainable, hence my question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
