sureshanaparti commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3063927493
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -883,10 +887,16 @@ protected enum HealthCheckResult {
private boolean convertInstanceVerboseMode = false;
private Map<String, String> convertInstanceEnv = null;
+ private String vddkLibDir = null;
+ private String libguestfsBackend = "direct";
Review Comment:
```suggestion
private static final String libguestfsBackend = "direct";
```
libguestfs has two main backends:
- libvirt (default)
- direct (QEMU directly)
The libvirt backend adds an extra virtualization layer and restricts device
access and networking paths. This conflicts with how Virtual Disk Development
Kit (VDDK) works, which needs direct disk/NBD access. So, need to keep 'direct'
for VDDK conversion. No need of any detail/property for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
