sureshanaparti commented on code in PR #12949:
URL: https://github.com/apache/cloudstack/pull/12949#discussion_r3043330093
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java:
##########
@@ -222,7 +223,7 @@ public VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot) {
}
}
if (!result) {
- for (SnapshotInfo snapshotInfo : forRollback) {
+ for (SnapshotInfo snapshotInfo :
volumeToSnapshotInfoMapForRollback.values()) {
Review Comment:
the snapshot info object after take snapshot can be new/updated one, which
will be considered during rollback. with HashSet, chances that another snapshot
object for the same volume is added if it's new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
