DaanHoogland commented on PR #12758: URL: https://github.com/apache/cloudstack/pull/12758#issuecomment-4091153172
> Hello, @DaanHoogland > > What about the alternate names I proposed based on your feedback and suggestions? @JoaoJandre , I won’t have time to go into this to deeply over the coming few weeks, so if you find consensus with the rest of the community that is fine, but personally, no, I don’t think createInternalBackupOffering, listInternalBackupOffering, and deleteInternalBackupOffering are good names. But this is a larger issue. I think the concept of “internal” would not fit with an implementation of the Backup&Restore framework. It would be, 1. a separate backup solution or (in which case these names could well fit) 2. adhere to the framework completely (making necessary changes to the framework if needed). I do not dictate which way we should go btw, I’m only observing that we are now half way. Apart from not having time over the next few weeks, I think there are enough people involved and don’t think I will add to the noise more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
