erikbocks opened a new pull request, #12862: URL: https://github.com/apache/cloudstack/pull/12862
### Description When listing network offerings with the `listNetworkOfferings` API, the VR's system offering ID is already returned. However, this information is not present at the GUI. Thus, changes were made to the `listNetworkOfferings` response to also return the system offering's name, and to the GUI to display the network offering's system offering as a column. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor ### Screenshots (if appropriate): <img width="2493" height="1323" alt="image" src="https://github.com/user-attachments/assets/ae700057-28ce-454a-9a47-3b2dffd1df6c" /> ### How Has This Been Tested? In a environment without the changes, the `Network Offerings` tab was accessed and I validated that there was no system offering information. With CloudMonkey, I called the `listNetworkOfferings` API and validated that the response contained only the system offering's ID. Then, after installing the packages containing the PR changes, I called the `listNetworkOfferings` API and validated that the API response now also returned the service offering's name. ``` { "displaytext": "Offering for Isolated networks with Source Nat service enabled", "name": "DefaultIsolatedNetworkOfferingWithSourceNatService", ... "serviceofferingid": "dde866be-b594-45c9-9a0f-f65b9f48ea0c", "serviceofferingname": "System Offering For Software Router", } ``` Via the GUI, the `Network Offering` tab was accessed and I validated that the network offering's system offering was also being displayed correctly (as it can be seen in the `Screenshots` section of the message). I also validated that the link to the system offering's page was working successfully and redirecting to the correct system offering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
