hsato03 opened a new pull request, #12819:
URL: https://github.com/apache/cloudstack/pull/12819
### Description
This PR introduces the `updateVmNic` API, allowing users to enable or
disable their VMs network interface cards (NICs).
Currently, this API supports only KVM with the following parameters:
| Parameter | Description
| Required |
| ------------------- |
-------------------------------------------------------------------- | --------
|
| `nicid` | The ID of the NIC that will be updated | - | Yes |
| `state` | Defines the NICs state. Values can be `Enabled` or `Disabled` |
No |
Future updates will extend this API to support additional NIC properties and
hypervisors.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
All tests were performed using only one NIC in the VM. Furthermore, the
results of all tests were obtained using the `ip a` command executed inside the
VM.
| N | Test | Result |
| --- | --- | --- |
| 1 | With the VM running, I changed the state of its NIC from `Enabled` to
`Disabled` | The NIC was DOWN |
| 2 | With the VM running, I changed the state of its NIC from `Disabled` to
`Enabled` | The NIC was UP |
| 3 | With the VM stopped, I started it with its NIC in the `Enabled` state
| The NIC was UP |
| 4 | With the VM stopped, I started it with its NIC in the `Disabled` state
| The NIC was DOWN |
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
