erikbocks commented on PR #12502: URL: https://github.com/apache/cloudstack/pull/12502#issuecomment-3847806574
Hello, @DaanHoogland and @RosiKyu I fixed the bug found in the `disableAccount` API. Regarding the questions raised in https://github.com/apache/cloudstack/pull/12502#issuecomment-3818472796: > what is the risk in case we (you) forgot some locations to change? The only impact that forgetting to change some locations would be event descriptions containing unstandardized messages, or internal IDs still being displayed (as seen in @RosiKyu's tests). Since this PR only changes event descriptions and does not interact with the event lifecycle, the behavior would remain the same. > how can we assess if we are complete? To update the event descriptions, I went through the usages of the `getEventDescription()` and `setEventDetails()` methods and updated them one by one. However, since both methods have many usages, there is a possibility that some were accidentally skipped. To validate whether all of them were changed or not, I think the only way is to check their usages one by one. I also think that, as the changes are mostly visual, we can proceed as is, and any skipped cases can be handled in future PRs. I will review the method usages again to ensure that no descriptions were missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
