winterhazel commented on code in PR #10505:
URL: https://github.com/apache/cloudstack/pull/10505#discussion_r2759062748
##########
engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java:
##########
@@ -262,7 +262,7 @@ public boolean isChildDomain(Long parentId, Long childId) {
SearchCriteria<DomainVO> sc = DomainPairSearch.create();
sc.setParameters("id", parentId, childId);
- List<DomainVO> domainPair = listBy(sc);
+ List<DomainVO> domainPair = listIncludingRemovedBy(sc);
Review Comment:
This method is not used in this PR. I'll remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
