winterhazel commented on code in PR #12522:
URL: https://github.com/apache/cloudstack/pull/12522#discussion_r2754432664
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -527,7 +527,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
public static final ConfigKey<Long> DELETE_QUERY_BATCH_SIZE = new
ConfigKey<>("Advanced", Long.class, "delete.query.batch.size", "0",
"Indicates the limit applied while deleting entries in bulk. With
this, the delete query will apply the limit as many times as necessary," +
" to delete all the entries. This is advised when
retaining several days of records, which can lead to slowness. <= 0 means that
no limit will " +
- "be applied. Default value is 0. For now, this is used for
deletion of vm & volume stats only.", true);
+ "be applied. Default value is 0. For now, this is used for
deletion of VM stats, volume stats, and usage records.", true);
Review Comment:
@DaanHoogland at least 500,000 by default seems like a good option for me. I
did some testing in a test environment with MariaDB and 80 million entries over
a laptop. Each stats/usage records batch took at most 5 seconds to delete, and
did not reach any timeouts. We need to validate how MySQL would perform, but
even 1,000,000 may be reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
